public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: john stultz <johnstul@us.ibm.com>
Cc: Andy Lutomirski <luto@amacapital.net>,
	linux-kernel@vger.kernel.org, Kumar Sundararajan <kumar@fb.com>,
	Arun Sharma <asharma@fb.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC 0/2] ABI for clock_gettime_ns
Date: Thu, 22 Dec 2011 13:03:26 +0100	[thread overview]
Message-ID: <20111222120326.GA3360@cherladcori01> (raw)
In-Reply-To: <1323889666.6805.71.camel@work-vm>

On Wed, Dec 14, 2011 at 11:07:46AM -0800, john stultz wrote:
> On Wed, 2011-12-14 at 19:30 +0100, Richard Cochran wrote:
> > 
> > So, you agree on adding new syscalls as a performance tweek?
> 
> Well, the patch that started this off was introducing a new vdso
> function (which had no syscall equivalent) that provided the same data
> as clock_gettime(CLOCK_THREAD_CPUTIME,...) but in ns format, because
> that was a reasonable performance win.

I don't see anything CLOCK_THREAD_CPUTIME in the patches, but I do see
CLOCK_REALTIME and CLOCK_MONOTONIC.

How is this about thread CPU time? (I assumed it was about fast time
stamps.)

> I don't think what is being proposed is trying to limit its use cases.
> The only limitation api wise was if we should return just nanoseconds or
> something with the potential for sub-ns values.

Yes, I do think new interfaces should anticipate sub-ns uses.

> > I mean to define an interface that always returns TAI values, no matter
> > what the clock device.
> 
> Maybe I'm still not understanding, but that seems more limited then what
> is being proposed, at least in my mind. clock_gettime_ns() would still
> take a clockid, so having a CLOCK_TAI would be a potential change in the
> future.

POSIX got the clock_gettime interface wrong, because you cannot tell
the time with it. The POSIX interface will return the same time value
for two consecutive seconds, due to leap seconds.

IMHO, new interfaces should correct this mistake. So, a new interface
providing UTC should also tell the user about leap seconds.

Just my 2 cents,

Richard

  parent reply	other threads:[~2011-12-22 12:03 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-13  1:26 [RFC 0/2] ABI for clock_gettime_ns Andy Lutomirski
2011-12-13  1:26 ` [RFC 1/2] Add clock_gettime_ns syscall Andy Lutomirski
2011-12-13  3:32   ` Richard Cochran
2011-12-13  1:26 ` [RFC 2/2] x86-64: Add __vdso_clock_gettime_ns vsyscall Andy Lutomirski
2011-12-13  3:24 ` [RFC 0/2] ABI for clock_gettime_ns Richard Cochran
2011-12-13  3:43   ` john stultz
2011-12-13  7:09     ` Andy Lutomirski
2011-12-14  7:46       ` Richard Cochran
2011-12-14 16:48         ` john stultz
2011-12-14 17:15           ` Andy Lutomirski
2011-12-14 17:31             ` john stultz
2011-12-14 18:37             ` Richard Cochran
2011-12-14 18:30           ` Richard Cochran
2011-12-14 19:07             ` john stultz
2011-12-14 19:20               ` Andy Lutomirski
2011-12-14 21:34                 ` john stultz
2011-12-15 11:35                   ` Richard Cochran
2011-12-22 12:03               ` Richard Cochran [this message]
2011-12-24  5:59                 ` Andy Lutomirski
2011-12-24  6:50                   ` Richard Cochran
2011-12-25  4:06                     ` Andy Lutomirski
2011-12-14  7:20     ` Richard Cochran
2011-12-14 16:23       ` john stultz
2011-12-14 18:21         ` Richard Cochran
2011-12-14 18:57           ` john stultz
2012-01-07 19:51             ` Richard Cochran
2011-12-21  0:50 ` Arun Sharma
2011-12-21  1:07   ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111222120326.GA3360@cherladcori01 \
    --to=richardcochran@gmail.com \
    --cc=asharma@fb.com \
    --cc=johnstul@us.ibm.com \
    --cc=kumar@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox