From: Tejun Heo <tj@kernel.org>
To: Mandeep Singh Baines <msb@chromium.org>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <paul@paulmenage.org>
Subject: Re: [PATCH 2/2] cgroup: remove extra calls to find_existing_css_set
Date: Thu, 22 Dec 2011 15:12:03 -0800 [thread overview]
Message-ID: <20111222231203.GO17084@google.com> (raw)
In-Reply-To: <1324592816-13792-2-git-send-email-msb@chromium.org>
On Thu, Dec 22, 2011 at 02:26:56PM -0800, Mandeep Singh Baines wrote:
> +out_list_teardown:
> + if (retval) {
> + for (i = 0; i < group_size; i++) {
> + tc = flex_array_get(group, i);
> + put_css_set(tc->cg);
> + }
> + }
Don't we need to put them even after success?
--
tejun
next prev parent reply other threads:[~2011-12-22 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 22:26 [PATCH 1/2] cgroup: remove tasklist_lock from cgroup_attach_proc Mandeep Singh Baines
2011-12-22 22:26 ` [PATCH 2/2] cgroup: remove extra calls to find_existing_css_set Mandeep Singh Baines
2011-12-22 23:12 ` Tejun Heo [this message]
2011-12-23 0:29 ` Mandeep Singh Baines
2011-12-22 22:51 ` [PATCH 1/2] cgroup: remove tasklist_lock from cgroup_attach_proc Tejun Heo
2011-12-23 0:58 ` Mandeep Singh Baines
-- strict thread matches above, loose matches on Subject: below --
2011-12-23 2:52 Mandeep Singh Baines
2011-12-23 2:52 ` [PATCH 2/2] cgroup: remove extra calls to find_existing_css_set Mandeep Singh Baines
2011-12-23 17:28 [PATCH 1/2] cgroup: replace tasklist_lock with rcu_read_lock Mandeep Singh Baines
2011-12-23 17:28 ` [PATCH 2/2] cgroup: remove extra calls to find_existing_css_set Mandeep Singh Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111222231203.GO17084@google.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=msb@chromium.org \
--cc=oleg@redhat.com \
--cc=paul@paulmenage.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox