From: Mandeep Singh Baines <msb@chromium.org>
To: Tejun Heo <tj@kernel.org>
Cc: Mandeep Singh Baines <msb@chromium.org>,
Li Zefan <lizf@cn.fujitsu.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <paul@paulmenage.org>
Subject: Re: [PATCH 1/2] cgroup: remove tasklist_lock from cgroup_attach_proc
Date: Thu, 22 Dec 2011 16:58:57 -0800 [thread overview]
Message-ID: <20111223005857.GL13529@google.com> (raw)
In-Reply-To: <20111222225102.GM17084@google.com>
Tejun Heo (tj@kernel.org) wrote:
> Hello,
>
> On Thu, Dec 22, 2011 at 02:26:55PM -0800, Mandeep Singh Baines wrote:
> > @@ -2283,14 +2261,26 @@ static int attach_task_by_pid(struct cgroup *cgrp, u64 pid, bool threadgroup)
> >
> > threadgroup_lock(tsk);
> >
> > - if (threadgroup)
> > + if (threadgroup) {
> > + if (!thread_group_leader(tsk)) {
> > + /*
> > + * a race with de_thread from another thread's exec()
> > + * may strip us of our leadership, if this happens,
> > + * there is no choice but to throw this task away and
> > + * try again (from cgroup_procs_write); this is
> > + * "double-double-toil-and-trouble-check locking".
> > + */
> > + ret = -EAGAIN;
> > + goto out_unlock_threadgroup;
> > + }
> > ret = cgroup_attach_proc(cgrp, tsk);
>
> Ummm... can't we just do tsk = tsk->leader after locking threadgroup?
You're right. Nice!
New series coming up.
> Why do we need to retry from the beginning?
>
> Thanks.
>
> --
> tejun
next prev parent reply other threads:[~2011-12-23 0:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 22:26 [PATCH 1/2] cgroup: remove tasklist_lock from cgroup_attach_proc Mandeep Singh Baines
2011-12-22 22:26 ` [PATCH 2/2] cgroup: remove extra calls to find_existing_css_set Mandeep Singh Baines
2011-12-22 23:12 ` Tejun Heo
2011-12-23 0:29 ` Mandeep Singh Baines
2011-12-22 22:51 ` [PATCH 1/2] cgroup: remove tasklist_lock from cgroup_attach_proc Tejun Heo
2011-12-23 0:58 ` Mandeep Singh Baines [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-23 2:52 Mandeep Singh Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111223005857.GL13529@google.com \
--to=msb@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=oleg@redhat.com \
--cc=paul@paulmenage.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox