From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752692Ab1LZG5d (ORCPT ); Mon, 26 Dec 2011 01:57:33 -0500 Received: from shutemov.name ([188.40.19.243]:55431 "EHLO shutemov.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476Ab1LZG50 convert rfc822-to-8bit (ORCPT ); Mon, 26 Dec 2011 01:57:26 -0500 Date: Mon, 26 Dec 2011 08:57:24 +0200 From: "Kirill A. Shutemov" To: KAMEZAWA Hiroyuki Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, Balbir Singh , Michal Hocko , Johannes Weiner , stable@vger.kernel.org Subject: Re: [PATCH 5/6] memcg: fix broken boolen expression Message-ID: <20111226065724.GA13459@shutemov.name> References: <1324695619-5537-1-git-send-email-kirill@shutemov.name> <1324695619-5537-5-git-send-email-kirill@shutemov.name> <20111226153138.0376bd66.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20111226153138.0376bd66.kamezawa.hiroyu@jp.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 26, 2011 at 03:31:38PM +0900, KAMEZAWA Hiroyuki wrote: > On Sat, 24 Dec 2011 05:00:18 +0200 > "Kirill A. Shutemov" wrote: > > > From: "Kirill A. Shutemov" > > > > action != CPU_DEAD || action != CPU_DEAD_FROZEN is always true. > > > > Signed-off-by: Kirill A. Shutemov > > maybe this should go stable.. CC stable@ > > Acked-by: KAMEZAWA Hiroyuki > > > > --- > > mm/memcontrol.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index b27ce0f..3833a7b 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -2100,7 +2100,7 @@ static int __cpuinit memcg_cpu_hotplug_callback(struct notifier_block *nb, > > return NOTIFY_OK; > > } > > > > - if ((action != CPU_DEAD) || action != CPU_DEAD_FROZEN) > > + if (action != CPU_DEAD && action != CPU_DEAD_FROZEN) > > return NOTIFY_OK; > > > > for_each_mem_cgroup(iter) > > -- > > 1.7.7.3 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe cgroups" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Kirill A. Shutemov