From: Alessandro Rubini <rubini@gnudd.com>
To: heiko.carstens@de.ibm.com
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] debugfs: add missing #ifdef HAS_IOMEM
Date: Tue, 27 Dec 2011 15:25:44 +0100 [thread overview]
Message-ID: <20111227142544.GA30402@mail.gnudd.com> (raw)
In-Reply-To: <1324994908-4288-1-git-send-email-heiko.carstens@de.ibm.com>
> "debugfs: add tools to printk 32-bit registers" adds new functions
> which rely on IOMEM functionality which is not present on all
> architectures and therefore result in compile errors:
Ok, my fault. I was thinking everybody has it.
Acked-by: Alessandro Rubini <rubini@gnudd.com>
(on the other hand, maybe the header should have it as well? I hate
ifdef so I'd better avoid it, but I don't know what the policy is in
this case: compile-error for implicit declaration or link error for
missing symbol? -- maybe a comment in the header is suitable?).
/alessandro
next prev parent reply other threads:[~2011-12-27 14:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 14:08 [PATCH -next] debugfs: add missing #ifdef HAS_IOMEM Heiko Carstens
2011-12-27 14:25 ` Alessandro Rubini [this message]
2012-01-04 0:44 ` Greg KH
2012-01-04 0:48 ` Al Viro
2012-01-04 0:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111227142544.GA30402@mail.gnudd.com \
--to=rubini@gnudd.com \
--cc=gregkh@suse.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox