From: Tejun Heo <tj@kernel.org>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH] cgroup: fix to allow mounting a hierarchy by name
Date: Tue, 27 Dec 2011 08:35:35 -0800 [thread overview]
Message-ID: <20111227163535.GA17712@google.com> (raw)
In-Reply-To: <4EF9291D.7030208@cn.fujitsu.com>
Hello, Li.
On Tue, Dec 27, 2011 at 10:10:37AM +0800, Li Zefan wrote:
> If we mount a hierarchy with a name specified, the name is unique,
> and we can use it to mount the hierarchy without specifying its
> set of subsystem names. This feature is documented is
> Documentation/cgroups/cgroups.txt section 2.3
>
> Here's an example:
>
> # mount -t cgroup -o cpuset,name=myhier xxx /cgroup1
> # mount -t cgroup -o name=myhier xxx /cgroup2
>
> But it was broken by commit 32a8cf235e2f192eb002755076994525cdbaa35a
> (cgroup: make the mount options parsing more accurate)
>
> This fixes the regression.
Hmmm... so that has been broken over a year and nobody complained? Is
there any valid use case where specifying mount path as all other
filesystems wouldn't work? Is this 'name' thing necessary at all?
Maybe we should rip it out instead of fixing it? We can just leave it
as non-functional name which does nothing but being visible in mount
listing.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-12-27 16:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 2:10 [PATCH] cgroup: fix to allow mounting a hierarchy by name Li Zefan
2011-12-27 6:25 ` [PATCH v2] " Li Zefan
2012-01-05 18:00 ` Tejun Heo
2011-12-27 16:35 ` Tejun Heo [this message]
2011-12-28 6:10 ` [PATCH] " Li Zefan
2011-12-28 6:12 ` Li Zefan
2011-12-28 16:36 ` Tejun Heo
2011-12-29 2:50 ` Li Zefan
2011-12-29 16:23 ` Tejun Heo
2011-12-30 5:58 ` Li Zefan
2012-01-05 2:20 ` Li Zefan
2012-01-05 17:45 ` Tejun Heo
2012-01-06 2:24 ` Li Zefan
2012-01-06 2:27 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111227163535.GA17712@google.com \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).