From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: gurligebis@gentoo.org, bhutchings@solarflare.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
rl@hellgate.ch
Subject: Re: [PATCH 1/1] via-rhine: Fix hanging with high CPU load on low-end broads.
Date: Wed, 28 Dec 2011 13:34:50 -0500 (EST) [thread overview]
Message-ID: <20111228.133450.479385013770977594.davem@davemloft.net> (raw)
In-Reply-To: <20111228101710.51c4893f@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 28 Dec 2011 10:17:10 -0800
> Looks like the hardware isn't really disabling interrupts correctly to support
> NAPI. NAPI is supposed to be friendly and under load the work should move to
> ksoftirqd. I suspect the IRQ management in this driver is borked.
> There is some stupid spin loops in the IRQ handler that happen when looking for
> Tx IRQ. I would run with debug set and see if this is triggering.
This could be simply a side effect of the fact that via-rhine only does
RX work in it's NAPI handler.
If all the work (or at least both TX and RX) were moved into the NAPI
handler, it'd probably be easier to properly shut off all IRQs during
NAPI processing, and thus avoid the high CPU load in the IRQ handler
being seen here.
This "shut off only some interrupts" scheme is just asking for trouble.
next prev parent reply other threads:[~2011-12-28 18:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 12:28 [PATCH 1/1] via-rhine: Fix hanging with high CPU load on low-end broads Bjarke Istrup Pedersen
2011-12-28 14:37 ` Ben Hutchings
2011-12-28 15:14 ` Bjarke Istrup Pedersen
2011-12-28 17:13 ` Ben Hutchings
2011-12-28 17:30 ` Bjarke Istrup Pedersen
2011-12-28 18:17 ` Stephen Hemminger
2011-12-28 18:34 ` David Miller [this message]
2011-12-28 19:16 ` Bjarke Istrup Pedersen
2011-12-29 15:39 ` Francois Romieu
2011-12-29 18:39 ` Francois Romieu
2011-12-29 22:00 ` Bjarke Istrup Pedersen
2011-12-29 22:05 ` David Miller
2011-12-29 23:19 ` Bjarke Istrup Pedersen
2011-12-29 23:37 ` Bjarke Istrup Pedersen
2011-12-29 23:48 ` David Miller
2011-12-30 1:18 ` Bjarke Istrup Pedersen
2011-12-29 23:53 ` Francois Romieu
2011-12-30 1:21 ` Bjarke Istrup Pedersen
2011-12-30 11:48 ` Bjarke Istrup Pedersen
2011-12-30 12:56 ` Francois Romieu
2011-12-30 13:51 ` Bjarke Istrup Pedersen
2011-12-30 18:03 ` Francois Romieu
2011-12-30 18:45 ` Bjarke Istrup Pedersen
2011-12-30 20:38 ` Bjarke Istrup Pedersen
2011-12-30 21:50 ` Francois Romieu
2011-12-30 22:08 ` Bjarke Istrup Pedersen
2011-12-30 22:08 ` Francois Romieu
2011-12-30 22:13 ` Bjarke Istrup Pedersen
2011-12-30 22:19 ` Francois Romieu
2011-12-30 22:41 ` Bjarke Istrup Pedersen
2011-12-31 1:37 ` Bjarke Istrup Pedersen
2011-12-31 12:17 ` Francois Romieu
2012-01-01 12:09 ` Bjarke Istrup Pedersen
2012-01-01 21:15 ` Bjarke Istrup Pedersen
2012-01-03 19:20 ` Bjarke Istrup Pedersen
2012-01-03 22:32 ` Francois Romieu
2012-01-04 7:59 ` Bjarke Istrup Pedersen
2012-01-05 12:01 ` Bjarke Istrup Pedersen
2012-01-05 16:20 ` Francois Romieu
2012-01-05 16:46 ` Bjarke Istrup Pedersen
2012-01-05 17:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111228.133450.479385013770977594.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=gurligebis@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rl@hellgate.ch \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox