From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595Ab1L3W20 (ORCPT ); Fri, 30 Dec 2011 17:28:26 -0500 Received: from violet.fr.zoreil.com ([92.243.8.30]:57754 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751939Ab1L3W2X (ORCPT ); Fri, 30 Dec 2011 17:28:23 -0500 Date: Fri, 30 Dec 2011 23:19:38 +0100 From: Francois Romieu To: Bjarke Istrup Pedersen Cc: David Miller , shemminger@vyatta.com, bhutchings@solarflare.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, rl@hellgate.ch Subject: Re: [PATCH 1/1] via-rhine: Fix hanging with high CPU load on low-end broads. Message-ID: <20111230221938.GA6197@electric-eye.fr.zoreil.com> References: <20111229235312.GA27092@electric-eye.fr.zoreil.com> <20111230125655.GA32031@electric-eye.fr.zoreil.com> <20111230180347.GA3647@electric-eye.fr.zoreil.com> <20111230215024.GA5513@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i X-Organisation: Land of Sunshine Inc. Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bjarke Istrup Pedersen : [...] > Does not build with patch: Neither did it here. My head is already elsewhere. [...] > Wouldn't it be an idea to move the declarations to a via-rhine.h file, > and include it, to work around it, and seperate it like it should be? Code could be correctly ordered too. Forward declare it. It's good enough in the meantime. -- Ueimor