Re: loading firmware while usermodehelper disabled.

Matthew Garrett
2011-12-31T00:40:29Z

On Fri, Dec 30, 2011 at 04:22:06PM -0800, Linus Torvalds wrote:

> It's isight_firmware_load(), in the isight_firmware driver. The driver
> doesn't actually do anything but load the firmware, and is apparently
> not very good at that either.
>
> It should either fake a disconnect and reconnect of the device (and
> let the reconnect then load the firmware through udev or something) or
> it should just save the firmware image in memory from the original
> load, and make the resume just re-initialize it - not load it.

Mm. My recollection is that these devices retained their firmware over
suspend/resume, so wouldn't resume with a USB id that matched the driver
and so this code shouldn't be called. It seems that either I was
horribly wrong about that, or something's changed in the USB layer
that's resulting in them resetting themselves. Newer devices don't
require this, so I'll need to try to chase up some older hardware to
figure out what's going on.

--
Matthew Garrett | mjg59@srcf.ucam.org