From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Donggeun Kim <dg77.kim@samsung.com>,
len.brown@intel.com, pavel@ucw.cz, rjw@sisk.pl,
rdunlap@xenotime.net, cbouatmailru@gmail.com,
pali.rohar@gmail.com, prakity@mavell.com, lars@metafoo.de,
kyungmin.park@samsung.com, myungjoo.ham@gmail.com
Subject: Re: [PATCH] regulator: add regulator_force_disable() definition for !CONFIG_REGULATOR
Date: Mon, 2 Jan 2012 11:40:49 +0000 [thread overview]
Message-ID: <20120102114049.GD2899@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1325497772-1817-1-git-send-email-myungjoo.ham@samsung.com>
On Mon, Jan 02, 2012 at 06:49:32PM +0900, MyungJoo Ham wrote:
> regulator_force_disable() was omitted in consumer.h for
> !CONFIG_REGULATOR case.
Applied, thanks.
> +static inline int regulator_force_disable(struct regulator *regulator)
> +{
> + return 0;
> +}
> +
I do think this'd be better returning an error - unlike the other stub
functions ignoring the attempt to force disable isn't within the bounds
of normal behaviour and if the consumer is trying to force disable at
all it's probably pretty urgent that the disable actually happens.
next prev parent reply other threads:[~2012-01-02 11:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 9:47 [PATCH v3 0/2] power: introduce Charger-Manager Donggeun Kim
2011-12-27 9:47 ` [PATCH v3 1/2] power: Charger-Manager: add initial Charger-Manager driver Donggeun Kim
2011-12-27 11:36 ` Mark Brown
2011-12-28 5:00 ` Donggeun Kim
2011-12-27 9:47 ` [PATCH v3 2/2] power: Charger-Manager: add properties for power-supply-class Donggeun Kim
2011-12-27 10:55 ` [PATCH v3 0/2] power: introduce Charger-Manager Mark Brown
2011-12-28 4:48 ` Donggeun Kim
2011-12-28 11:05 ` Mark Brown
2012-01-02 9:49 ` [PATCH] regulator: add regulator_force_disable() definition for !CONFIG_REGULATOR MyungJoo Ham
2012-01-02 11:40 ` Mark Brown [this message]
2012-01-04 4:11 ` [PATCH v3 0/2] power: introduce Charger-Manager Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120102114049.GD2899@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cbouatmailru@gmail.com \
--cc=dg77.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lars@metafoo.de \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=prakity@mavell.com \
--cc=rdunlap@xenotime.net \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).