From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753239Ab2ABR3b (ORCPT ); Mon, 2 Jan 2012 12:29:31 -0500 Received: from cantor2.suse.de ([195.135.220.15]:53690 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752944Ab2ABR3a (ORCPT ); Mon, 2 Jan 2012 12:29:30 -0500 Date: Mon, 2 Jan 2012 09:28:44 -0800 From: Greg KH To: Konstantin Khlebnikov Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] tty: cleanup prohibition of direct opening for unix98 pty master Message-ID: <20120102172844.GA19782@suse.de> References: <20120102172231.11476.57711.stgit@zurg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120102172231.11476.57711.stgit@zurg> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 02, 2012 at 09:22:31PM +0400, Konstantin Khlebnikov wrote: > cleanup hack added in v2.6.27-3203-g15582d3 > > comment from that patch: > > : pty: If the administrator creates a device for a ptmx slave we should not error > : > : The open path for ptmx slaves is via the ptmx device. Opening them any > : other way is not allowed. Vegard Nossum found that previously this was not > : the case and mknod foo c 128 42; cat foo would produce nasty diagnostics > : > : Signed-off-by: Alan Cox > : Signed-off-by: Linus Torvalds Any reason why you didn't include these two people on this patch? Perhaps they might wish to review it... greg k-h