From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755885Ab2ACXAJ (ORCPT ); Tue, 3 Jan 2012 18:00:09 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:46389 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755724Ab2ACWh4 (ORCPT ); Tue, 3 Jan 2012 17:37:56 -0500 Date: Tue, 3 Jan 2012 14:37:54 -0800 From: Andrew Morton To: Gilad Ben-Yossef Cc: KOSAKI Motohiro , linux-kernel@vger.kernel.org, Christoph Lameter , Chris Metcalf , Peter Zijlstra , Frederic Weisbecker , linux-mm@kvack.org, Pekka Enberg , Matt Mackall , Sasha Levin , Rik van Riel , Andi Kleen , Mel Gorman , Alexander Viro , Avi Kivity Subject: Re: [PATCH v5 8/8] mm: add vmstat counters for tracking PCP drains Message-Id: <20120103143754.f2640d24.akpm@linux-foundation.org> In-Reply-To: References: <1325499859-2262-1-git-send-email-gilad@benyossef.com> <1325499859-2262-9-git-send-email-gilad@benyossef.com> <4F033F44.6020403@gmail.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Jan 2012 21:00:17 +0200 Gilad Ben-Yossef wrote: > > NAK. > > > > PCP_GLOBAL_IPI_SAVED is only useful at development phase. I can't > > imagine normal admins use it. > > As the description explains, the purpose of the patch is to show why i > claim the previous > patch is useful. I did not meant it to be applied to mainline. Right. The thing to do is to use this patch to determine the effectiveness of the preceding patchset and then present a summary of the results in the other patch's changelog. This is precisely what you did and the results look pretty good.