Re: loading firmware while usermodehelper disabled.

Matthew Garrett
2012-01-02T22:12:45Z

On Mon, Jan 02, 2012 at 02:03:27PM -0800, Linus Torvalds wrote:
> On Mon, Jan 2, 2012 at 1:50 PM, Matthew Garrett <mjg@redhat.com> wrote:
> > On Mon, Jan 02, 2012 at 01:27:03PM -0800, Linus Torvalds wrote:
> >
> >> If we didn't load the firmware before the suspend, then the resume
> >> function of a device sure as hell had better not load it at resume
> >> time either.
> >
> > If the hardware has lost its state then refusing to load the firmware at
> > resume time isn't going to leave you with a working device.
>
> What the heck is your problem?
>
> Go back and read it.
>
> If it wasn't loaded before, THEN IT WASN'T WORKING BEFORE EITHER! And
> if it was loaded before, then it would be cached (and thus trivially
> reloaded without having to invoke user-space or disk devices that may
> not be running) and thus loading it would work.

The kernel that loaded the firmware to make the device work is not
required to be the same kernel that we're running when we suspend. The
hardware keeps its firmware over warm reboots, and if it already has
loaded firmware then we have no way of knowing that it needs firmware at
all.

--
Matthew Garrett | mjg59@srcf.ucam.org