From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754204Ab2ACRIC (ORCPT ); Tue, 3 Jan 2012 12:08:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30338 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754154Ab2ACRH7 (ORCPT ); Tue, 3 Jan 2012 12:07:59 -0500 Date: Tue, 3 Jan 2012 22:37:48 +0530 From: Amit Shah To: "Michael S. Tsirkin" Cc: Virtualization List , Rusty Russell , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v6 09/11] virtio: net: Add freeze, restore handlers to support S4 Message-ID: <20120103170748.GE4536@amit.redhat.com> References: <20111229161523.GB2300@redhat.com> <20111230085205.GG4576@amit.redhat.com> <20120101114727.GC25350@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120101114727.GC25350@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (Sun) 01 Jan 2012 [13:47:27], Michael S. Tsirkin wrote: > On Fri, Dec 30, 2011 at 03:08:19PM +0530, Amit Shah wrote: > > > > > > > + if (!try_fill_recv(vi, GFP_KERNEL)) > > > > + schedule_delayed_work(&vi->refill, 0); > > > > > > This needs to be switched to non reentrant wq too? > > > > Subsequent invocations could create problems? Note that this will be > > the first item to be queued in the workqueue for the refill work. > > > > Amit > > See recent patches on net-next. > We switched other calls to a non reentrant wq so I think same > reasoning applies there. There's a patch ordering issue; so this series should land after the -net series is merged. Rusty, do you want me to re-spin this patch on top of yours, or is that something that you'll handle? Amit