From: Greg KH <greg@kroah.com>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org,
Alessandro Rubini <rubini@gnudd.com>
Subject: Re: [PATCH -next] debugfs: add missing #ifdef HAS_IOMEM
Date: Tue, 3 Jan 2012 16:44:52 -0800 [thread overview]
Message-ID: <20120104004452.GA22949@kroah.com> (raw)
In-Reply-To: <1324994908-4288-1-git-send-email-heiko.carstens@de.ibm.com>
On Tue, Dec 27, 2011 at 03:08:28PM +0100, Heiko Carstens wrote:
> "debugfs: add tools to printk 32-bit registers" adds new functions which rely
> on IOMEM functionality which is not present on all architectures and therefore
> result in compile errors:
>
> fs/debugfs/file.c: In function 'debugfs_print_regs32':
> fs/debugfs/file.c:561:7: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
Who does not have readl()? Surely there should be a .h file we are just
missing to include?
> Add an #ifdef CONFIG_HAS_IOMEM to fix this
I guess this is ok, thanks for the patch.
greg k-h
next prev parent reply other threads:[~2012-01-04 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 14:08 [PATCH -next] debugfs: add missing #ifdef HAS_IOMEM Heiko Carstens
2011-12-27 14:25 ` Alessandro Rubini
2012-01-04 0:44 ` Greg KH [this message]
2012-01-04 0:48 ` Al Viro
2012-01-04 0:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104004452.GA22949@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@gnudd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox