From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758201Ab2AES6H (ORCPT ); Thu, 5 Jan 2012 13:58:07 -0500 Received: from shards.monkeyblade.net ([198.137.202.13]:33601 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494Ab2AES6E (ORCPT ); Thu, 5 Jan 2012 13:58:04 -0500 Date: Thu, 05 Jan 2012 13:57:51 -0500 (EST) Message-Id: <20120105.135751.2230446777137893740.davem@davemloft.net> To: cascardo@linux.vnet.ibm.com Cc: venkat.x.venkatsubra@oracle.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dledford@redhat.com, Jes.Sorensen@redhat.com, rds-devel@oss.oracle.com Subject: Re: [PATCH] rds_rdma: don't assume infiniband device is PCI From: David Miller In-Reply-To: <20120105170523.GA19022@oc1711230544.ibm.com> References: <20120105170523.GA19022@oc1711230544.ibm.com> X-Mailer: Mew version 6.4 on Emacs 23.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Thu, 05 Jan 2012 10:57:56 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thadeu Lima de Souza Cascardo Date: Thu, 5 Jan 2012 15:05:24 -0200 > On Thu, Jan 05, 2012 at 08:56:34AM -0800, Venkat Venkatsubra wrote: >> Hi Cascardo, >> >> Your changes look good to me. >> But our latest code doesn't use this rdsibdev_to_node macro anywhere. >> Checking with the people in my group who know the history of the NUMA feature. >> Trying to find out if the call to kzalloc_node() can be replaced by kzalloc(). >> In which case this macro can be removed. >> >> I will keep you posted. >> >> Venkat >> > > Hi, Venkat. > > Do you have any public tree where we can track the last changes in RDS? > Note that I have changed ibsdev_to_node, which rdsibdev_to_node makes > use of. Anyway, replacing kzalloc_node with kzalloc has crossed my mind, > but since I was not sure if this would affect latency of RDS in any use > cases, I kept that and used a better function to get the node from the > device. And we have dev_to_node since 2.6.20, so it should not be a > problem to use it. > > If possible, keep everyone copied and avoid top posting. Indeed, otherwise it's impossible for anyone to follow the progress on this patch. If anything, you should never remove netdev from the CC: list when discussing a patch. Otherwise the followups don't make into our patch tracking system at: http://patchwork.ozlabs.org/project/netdev/list/