From: Alan Cox <alan@linux.intel.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-kernel@vger.kernel.org, "Greg KH" <greg@kroah.com>
Subject: Re: [PATCH] serial/documentation: fix name of DCD cpp symbol
Date: Thu, 5 Jan 2012 00:37:53 +0000 [thread overview]
Message-ID: <20120105003753.1e6d2ed2@bob.linux.org.uk> (raw)
In-Reply-To: <4F04DD19.1070602@xenotime.net>
On Wed, 04 Jan 2012 15:13:29 -0800
Randy Dunlap <rdunlap@xenotime.net> wrote:
> On 12/02/2011 03:42 PM, Alan Cox wrote:
> > On Fri, 2 Dec 2011 21:20:11 +0100
> > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> >
> >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >> ---
> >> Documentation/serial/driver | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/Documentation/serial/driver
> >> b/Documentation/serial/driver index 77ba0af..0a25a91 100644
> >> --- a/Documentation/serial/driver
> >> +++ b/Documentation/serial/driver
> >> @@ -101,7 +101,7 @@ hardware.
> >> Returns the current state of modem control inputs. The
> >> state of the outputs should not be returned, since the core keeps
> >> track of their state. The state information should
> >> include:
> >> - - TIOCM_DCD state of DCD signal
> >> + - TIOCM_CAR state of DCD signal
> >> - TIOCM_CTS state of CTS signal
> >> - TIOCM_DSR state of DSR signal
> >> - TIOCM_RI state of RI signal
> >
> > Acked-by: Alan Cox <alan@linux.intel.com>
> >
> > but please fix the Subject line to be less confusing - it sounds
> > like it changes the define not the docs...
>
>
> (sorry for the delayed reply)
>
> I thought that DCD meant Data Carrier Detect. Is that old? Has it
> changed to just Carrier?
TIOCM_ are the kernel names. The documentation says we use TIOCM_DCD -
only we don't - the #define is TIOCM_CAR
So its a fix.
prev parent reply other threads:[~2012-01-05 0:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 20:20 [PATCH] serial/documentation: fix name of DCD cpp symbol Uwe Kleine-König
2011-12-02 23:42 ` Alan Cox
2012-01-04 23:13 ` Randy Dunlap
2012-01-04 22:24 ` Greg KH
2012-01-05 0:37 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105003753.1e6d2ed2@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox