public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/1] regulator: set constraints.apply_uV to 0 in of_get_fixed_voltage_config
       [not found] <1325225213-29655-1-git-send-email-richard.zhao@linaro.org>
@ 2012-01-04  3:07 ` Richard Zhao
  2012-01-06  9:51   ` Richard Zhao
  2012-01-06 19:01   ` Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: Richard Zhao @ 2012-01-04  3:07 UTC (permalink / raw)
  To: linux-pm, linux-arm-kernel, linux-kernel
  Cc: broonie, lrg, patches, eric.miao, Richard Zhao

Fix fixed regulator using DT failed to call regulator_register.

of_get_regulator_init_data set apply_uV to 1, but fixed regulator
doesn't need it. Set it back to 0.

Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
---
 drivers/regulator/fixed.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
index 393f039..e24e3a1 100644
--- a/drivers/regulator/fixed.c
+++ b/drivers/regulator/fixed.c
@@ -69,6 +69,7 @@ of_get_fixed_voltage_config(struct device *dev)
 		return NULL;
 
 	init_data = config->init_data;
+	init_data->constraints.apply_uV = 0;
 
 	config->supply_name = init_data->constraints.name;
 	if (init_data->constraints.min_uV == init_data->constraints.max_uV) {
-- 
1.7.5.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] regulator: set constraints.apply_uV to 0 in of_get_fixed_voltage_config
  2012-01-04  3:07 ` [PATCH v2 1/1] regulator: set constraints.apply_uV to 0 in of_get_fixed_voltage_config Richard Zhao
@ 2012-01-06  9:51   ` Richard Zhao
  2012-01-06 18:43     ` Mark Brown
  2012-01-06 19:01   ` Mark Brown
  1 sibling, 1 reply; 4+ messages in thread
From: Richard Zhao @ 2012-01-06  9:51 UTC (permalink / raw)
  To: Richard Zhao
  Cc: linux-pm, linux-arm-kernel, linux-kernel, broonie, lrg, eric.miao,
	patches

Hi Mark,

What do you think of the patch?

Thanks
Richard 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] regulator: set constraints.apply_uV to 0 in of_get_fixed_voltage_config
  2012-01-06  9:51   ` Richard Zhao
@ 2012-01-06 18:43     ` Mark Brown
  0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-01-06 18:43 UTC (permalink / raw)
  To: Richard Zhao
  Cc: Richard Zhao, linux-pm, linux-arm-kernel, linux-kernel, lrg,
	eric.miao, patches

On Fri, Jan 06, 2012 at 05:51:18PM +0800, Richard Zhao wrote:

> What do you think of the patch?

I think context is important when sending e-mails, as is not burying
your mail in the middle of old threads.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 1/1] regulator: set constraints.apply_uV to 0 in of_get_fixed_voltage_config
  2012-01-04  3:07 ` [PATCH v2 1/1] regulator: set constraints.apply_uV to 0 in of_get_fixed_voltage_config Richard Zhao
  2012-01-06  9:51   ` Richard Zhao
@ 2012-01-06 19:01   ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-01-06 19:01 UTC (permalink / raw)
  To: Richard Zhao
  Cc: linux-pm, linux-arm-kernel, linux-kernel, lrg, patches, eric.miao

On Wed, Jan 04, 2012 at 11:07:29AM +0800, Richard Zhao wrote:
> Fix fixed regulator using DT failed to call regulator_register.
> 
> of_get_regulator_init_data set apply_uV to 1, but fixed regulator
> doesn't need it. Set it back to 0.

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-01-06 19:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1325225213-29655-1-git-send-email-richard.zhao@linaro.org>
2012-01-04  3:07 ` [PATCH v2 1/1] regulator: set constraints.apply_uV to 0 in of_get_fixed_voltage_config Richard Zhao
2012-01-06  9:51   ` Richard Zhao
2012-01-06 18:43     ` Mark Brown
2012-01-06 19:01   ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox