public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ted Ts'o" <tytso@mit.edu>
To: Shantanu Goel <sgoel01@yahoo.com>
Cc: Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext4: Fix up range_end offset in range cyclic writeback
Date: Mon, 9 Jan 2012 10:17:07 -0500	[thread overview]
Message-ID: <20120109151707.GB22175@thunk.org> (raw)
In-Reply-To: <1325993012.29526.YahooMailNeo@web38004.mail.mud.yahoo.com>

On Sat, Jan 07, 2012 at 07:23:32PM -0800, Shantanu Goel wrote:
> 
> 
> The patch below fixes the range_end calculation which should be a
> byte offset and not a page index.  Also, the patch updates the `end'
> index as well when looping again in range cyclic mode.

Hi Shantanu,

This patch looks good; thanks for spotting this!  Can I ask how you
spotted this and whether it was by code inspection because the
incorrect code was causing some serious problem?

Basically, it's late in the merge window, and I'd rather not include
any new patches unless they are fixing a serious problem at this
point.  Otherwise, I'll make sure it gets merged for the next merge
window.

Thanks,

						- Ted

  reply	other threads:[~2012-01-09 15:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-08  3:23 [PATCH] ext4: Fix up range_end offset in range cyclic writeback Shantanu Goel
2012-01-09 15:17 ` Ted Ts'o [this message]
2012-01-09 15:49   ` Shantanu Goel
     [not found]   ` <1326123988.9602.YahooMailNeo@web38004.mail.mud.yahoo.com>
2012-01-09 15:50     ` Ted Ts'o
2012-01-09 16:20       ` Shantanu Goel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120109151707.GB22175@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sgoel01@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox