Re: [PATCH] ext4: Fix up range_end offset in range cyclic writeback

Ted Ts'o
2012-01-09T15:50:21Z

On Mon, Jan 09, 2012 at 07:46:28AM -0800, Shantanu Goel wrote:
>
> Thanks for confirming the fix is good.  We noticed that kupdate
> writebacks were happening at irregular intervals

So this was a performance issue that led you to this investigation?
How much of a performance issue are we talking about?

If it's a correctness issue that might lead to data loss because
fsync() wasn't doing its jobs, that's obviously higher priority than a
performance issue.

Again, I just wanted to characterize this correctly in the commit ---
BTW, this is good stuff to include in the commit description so in the
future, developers trying to go through the history can understand why
a particular patch is important (perhaps to backport into an
enterprise distro release, etc.)

Thanks, regards,

- Ted