Re: [PATCH] ext4: Fix up range_end offset in range cyclic writeback

Ted Ts'o
2012-01-09T15:17:10Z

On Sat, Jan 07, 2012 at 07:23:32PM -0800, Shantanu Goel wrote:
>
>
> The patch below fixes the range_end calculation which should be a
> byte offset and not a page index.  Also, the patch updates the `end'
> index as well when looping again in range cyclic mode.

Hi Shantanu,

This patch looks good; thanks for spotting this! Can I ask how you
spotted this and whether it was by code inspection because the
incorrect code was causing some serious problem?

Basically, it's late in the merge window, and I'd rather not include
any new patches unless they are fixing a serious problem at this
point. Otherwise, I'll make sure it gets merged for the next merge
window.

Thanks,

- Ted