Re: [PATCH] modules: sysfs - export: taint, address, size

[Nick Bowler <nbowler@elliptictech.com>]

On 2012-01-07 16:44 +0100, Kay Sievers wrote:
> From: Kay Sievers <kay.sievers@vrfy.org>
> Subject: modules: sysfs - export taint, address, size
> 
> Recent tools do not use /proc to retrieve module information. A few values
> are currently missing from sysfs.
[...]
> @@ -907,10 +927,8 @@ static ssize_t show_refcnt(struct module
>  	return sprintf(buffer, "%u\n", module_refcount(mk->mod));
>  }
>  
> -static struct module_attribute refcnt = {
> -	.attr = { .name = "refcnt", .mode = 0444 },
> -	.show = show_refcnt,
> -};
> +static struct module_attribute refcnt =
> +	__ATTR(refcnt, 0444, show_refcnt, NULL);

This change seems unrelated to the patch description, and is not
mentioned in the changelog.  Several instances of this.

[...]
>  static struct module_attribute *modinfo_attrs[] = {
>  	&modinfo_version,
>  	&modinfo_srcversion,
> -	&initstate,
> +	&module_initstate,

Another unrelated change?

>  	&module_uevent,
> +	&module_address,
> +	&module_size,
> +	&module_taint,

You've forgotten to update Documentation/ABI to describe these new
attributes.

Cheers,
-- 
Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)