From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Krystian Garbaciak <dd.diasemi@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: drivers/regulator/core.c: Fixes mapping inside regulator_mode_to_status() and makes it returning -EINVAL on invalid input.
Date: Mon, 9 Jan 2012 08:14:57 -0800 [thread overview]
Message-ID: <20120109161456.GC2974@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1326111140.22107.9.camel@sw-eng-lt-dc-vm2>
On Mon, Jan 09, 2012 at 12:12:20PM +0000, Krystian Garbaciak wrote:
> Minor fix that makes the function working correctly with
> REGULATOR_MODE_STANDBY as parameter.
> Also, on invalid input (bad mode), it is better to return -EINVAL,
> instead of meaningless 0 value (which actually is interpreted as
> REGULATOR_STATUS_OFF).
>
> ---
As I previously said you need to follow the patch submission process in
SubmittingPatches. Here you need to:
- Sign off your patch. Without this your patch cannot be applied.
- Send the patches to the maintainers (not just one of them) and the
list.
You should also make an effort to use subject lines for your patch that
match up with what the rest of the subsystem is doing.
> default:
> - return 0;
> + return -EINVAL;
This behaviour is deliberate.
next prev parent reply other threads:[~2012-01-09 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 12:12 drivers/regulator/core.c: Fixes mapping inside regulator_mode_to_status() and makes it returning -EINVAL on invalid input Krystian Garbaciak
2012-01-09 16:14 ` Mark Brown [this message]
2012-01-09 19:20 ` dd diasemi
2012-01-09 20:07 ` Mark Brown
2012-01-10 0:11 ` dd diasemi
2012-01-10 0:14 ` Mark Brown
2012-01-10 17:09 ` dd diasemi
2012-01-10 17:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109161456.GC2974@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dd.diasemi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).