From: Tejun Heo <tj@kernel.org>
To: Namhyung Kim <namhyung.kim@lge.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] block: introduce BIO_IN_FLIGHT flag
Date: Mon, 9 Jan 2012 08:41:48 -0800 [thread overview]
Message-ID: <20120109164148.GB21732@google.com> (raw)
In-Reply-To: <4F0A57A7.4070508@lge.com>
Hello,
On Mon, Jan 09, 2012 at 11:57:43AM +0900, Namhyung Kim wrote:
> I understand your concerns. However, the blktrace cannot get
> bio->bi_flags info in its current form AFAIK. Doing it will require
> extending struct blk_io_trace and it'll cause a compatibility issue,
> I guess.
Umm? Why can't blk_add_trace_bio_complete() look at the flags (or
whatever other states) to decide to fire off BLK_TA_COMPLETE or not?
What's the difference? No userland visible change is necessary at
all. Just make blktrace.c do the right thing. Am I missing
something?
Thanks.
--
tejun
next prev parent reply other threads:[~2012-01-09 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 14:28 [PATCH -block/for-next 0/2] blktrace: bio-based device tracing improvement v3 Namhyung Kim
2011-12-27 14:28 ` [PATCH 1/2] block: introduce BIO_IN_FLIGHT flag Namhyung Kim
2012-01-09 1:56 ` Tejun Heo
2012-01-09 2:57 ` Namhyung Kim
2012-01-09 16:41 ` Tejun Heo [this message]
2012-01-10 5:06 ` Namhyung Kim
2012-01-10 16:26 ` Tejun Heo
2011-12-27 14:28 ` [PATCH 2/2] block: don't export block_bio_complete tracepoint Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109164148.GB21732@google.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung.kim@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).