From: Greg KH <greg@kroah.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Frank Mandarino <fmandarino@endrelia.com>,
Liam Girdwood <lrg@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: Public ridicule due to sound/soc/soc-core.c abuse of the driver model
Date: Mon, 9 Jan 2012 15:02:29 -0800 [thread overview]
Message-ID: <20120109230229.GA11470@kroah.com> (raw)
In-Reply-To: <20120109203129.GA25743@opensource.wolfsonmicro.com>
On Mon, Jan 09, 2012 at 12:31:30PM -0800, Mark Brown wrote:
> On Mon, Jan 09, 2012 at 12:11:10PM -0800, Greg KH wrote:
> > On Mon, Jan 09, 2012 at 07:52:13PM +0000, Mark Brown wrote:
>
> > > Trying to make any sort of modification to code this fragile is risky,
> > > especially during what's supposed to be a stabalization phase (which is
> > > what Greg is requesting). It just seems completely irresponsible for
> > > something that isn't actually a practical problem.
>
> > I find it hard to believe that ignoring the driver model is not a
> > "practical" problem :)
>
> > For details as to why this is a problem, please see the kobject.txt
> > file.
>
> Sure, I'm fully aware of the issue. The reason this is so painful to
> work with is that AC'97 is just generally doing a really bad job of
> using the driver model.
>
> > Please fix this up, as you have seen, people end up cutting-and-pasting
> > bad code.
>
> In my copious free time, but like I say trying to do this for 3.3 (you
> only posted *after* the merge window opened) is just nuts and I'd rather
> hope someone who cares about AC'97 systems will come forward and work on
> it (having one would be a real bonus). If people actually had problems
> we were fixing that'd be one thing but if they do they're being
> extremely quiet about it.
Ok, fair enough, if this is fixed by 3.4, I'll be happy.
thanks,
greg k-h
next prev parent reply other threads:[~2012-01-09 23:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 19:40 Public ridicule due to sound/soc/soc-core.c abuse of the driver model Greg KH
2012-01-06 20:15 ` Mark Brown
2012-01-06 20:50 ` Russell King - ARM Linux
2012-01-06 21:10 ` Russell King - ARM Linux
2012-01-06 23:41 ` Mark Brown
2012-01-06 23:44 ` Russell King - ARM Linux
2012-01-06 23:49 ` Mark Brown
2012-01-09 9:51 ` Russell King - ARM Linux
2012-01-09 19:52 ` Mark Brown
2012-01-09 20:11 ` Greg KH
2012-01-09 20:31 ` Mark Brown
2012-01-09 21:37 ` Russell King - ARM Linux
2012-01-09 22:16 ` Mark Brown
2012-01-09 23:02 ` Greg KH [this message]
2012-01-06 20:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109230229.GA11470@kroah.com \
--to=greg@kroah.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=fmandarino@endrelia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@ti.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox