From: Oleg Nesterov <oleg@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Masami Hiramatsu <mhiramat@redhat.com>,
Seiji Aguchi <saguchi@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] tracing: make signal tracepoints more useful
Date: Tue, 10 Jan 2012 18:45:09 +0100 [thread overview]
Message-ID: <20120110174509.GA30802@redhat.com> (raw)
Hello.
Linus, I am asking you to review (and hopefully apply) these
changes, I do not know who else can do this. I do not mean the
implementation, the patches are simple. Just the behavioural
change.
2/2 looks like a bugfix to me, but 1/2 changes the output from
trace_signal_generate() and removes trace_signal_overflow_fail.
In essence the change is:
- TP_printk("sig=%d errno=%d code=%d comm=%s pid=%d",
+ TP_printk("sig=%d errno=%d code=%d comm=%s pid=%d grp=%d res=%d",
where
- grp=0/1 means private or shared
- res is enum {
TRACE_SIGNAL_DELIVERED,
TRACE_SIGNAL_IGNORED,
TRACE_SIGNAL_ALREADY_PENDING,
TRACE_SIGNAL_OVERFLOW_FAIL,
TRACE_SIGNAL_LOSE_INFO,
};
Obviously this is the user visible change. But personally I do
agree with Seiji who requested this feature. Currently
trace_signal_generate() just records the fact that __send_signal()
was called, you can't know whether the signal was actually sent
or not.
include/trace/events/signal.h | 85 +++++++++++------------------------------
kernel/signal.c | 28 +++++++++----
2 files changed, 41 insertions(+), 72 deletions(-)
next reply other threads:[~2012-01-10 17:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 17:45 Oleg Nesterov [this message]
2012-01-10 17:45 ` [PATCH 1/2] tracing: let trace_signal_generate() report more info, kill overflow_fail/lose_info Oleg Nesterov
2012-01-10 17:45 ` [PATCH 2/2] tracing: send_sigqueue() needs trace_signal_generate() too Oleg Nesterov
2012-01-10 18:59 ` [PATCH 0/2] tracing: make signal tracepoints more useful Steven Rostedt
2012-01-10 21:09 ` Seiji Aguchi
2012-01-13 18:20 ` [GIT PULL] " Oleg Nesterov
2012-01-15 18:24 ` Oleg Nesterov
2012-01-16 7:45 ` Ingo Molnar
2012-01-16 12:31 ` Steven Rostedt
2012-01-16 12:53 ` Ingo Molnar
2012-01-16 15:10 ` Oleg Nesterov
2012-01-17 18:50 ` Linus Torvalds
2012-01-18 9:39 ` Ingo Molnar
2012-01-16 15:52 ` Steven Rostedt
2012-01-17 10:02 ` Ingo Molnar
2012-01-17 12:03 ` Steven Rostedt
2012-01-17 12:40 ` Ingo Molnar
2012-01-17 14:04 ` Oleg Nesterov
2012-01-18 11:59 ` Ingo Molnar
2012-01-17 14:37 ` Steven Rostedt
2012-01-17 14:55 ` Oleg Nesterov
2012-01-20 18:01 ` Jason Baron
2012-01-17 19:52 ` Steven Rostedt
2012-01-16 15:03 ` Oleg Nesterov
2012-01-16 15:42 ` Seiji Aguchi
2012-01-16 15:58 ` Steven Rostedt
2012-01-26 10:10 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110174509.GA30802@redhat.com \
--to=oleg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=saguchi@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).