public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Cc: Pavel Emelyanov <xemul@parallels.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Kyle Moffett <kyle@moffetthome.net>, Tejun Heo <tj@kernel.org>,
	Glauber Costa <glommer@parallels.com>,
	Andi Kleen <andi@firstfloor.org>,
	Matt Helsley <matthltc@us.ibm.com>,
	Pekka Enberg <penberg@kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Vasiliy Kulikov <segoon@openwall.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Herbert Xu <herbert@gondor.hengli.com.au>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Andrey Vagin <avagin@openvz.org>
Subject: Re: [RFC] on general object IDs again
Date: Wed, 11 Jan 2012 22:31:15 +0400	[thread overview]
Message-ID: <20120111183115.GA28196@moon> (raw)
In-Reply-To: <4F0DD365.6070200@parallels.com>

On Wed, Jan 11, 2012 at 10:22:29PM +0400, Pavel Emelyanov wrote:
> On 01/11/2012 10:19 PM, KOSAKI Motohiro wrote:
> >> Hi Kosaki,
> >>
> >> the idea on user-space is something like
> >>
> >>  - collect all pids to dump
> >>  - collect IDs for every pid
> >>  - sort the IDs obtained
> >>  - find the same IDs (which will be kind of find intersections in a sets of IDs) and
> >>   set up CLONE_ flags on restore procedure as appropriate (for example if
> >>   GEN_OBJ_ID_VM IDs for two or more tasks are the same we need to use CLONE_VM
> >>   at restore time, and so on).
> > 
> > Then, you only need to compare. not any other calculation. i.e. only
> > need id uniqueness.
> > And any resource are referenced from tasks. so, can you reuse pid for
> > this? example,
> > two taska share one mm.
> > 
> > task-a(pid: 100)
> >               |-----------------mm
> > task-b(pid: 200)
> > 
> > 
> > gen_obj_id(task-b, GEN_OBJ_ID_VM) return 100. (youngest pid of referenced tasks)
> 
> We can, but determining the youngest pid for an mm struct is O(N) algo.
> Having N tasks with N mm_structs getting the sharing picture becomes O(N^2).
> 

Yeah, exactly. If not the speed problem we would simply stick
with Andrew's proposal as two-id-are-the-same(pid1, pid2)
syscall. But when we get a number of pids to dump we need the
resource affinity picture over them all.

	Cyrill

  reply	other threads:[~2012-01-11 18:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11 16:19 [RFC] on general object IDs again Cyrill Gorcunov
2012-01-11 17:25 ` KOSAKI Motohiro
2012-01-11 17:59   ` Cyrill Gorcunov
2012-01-11 18:19     ` KOSAKI Motohiro
2012-01-11 18:22       ` Pavel Emelyanov
2012-01-11 18:31         ` Cyrill Gorcunov [this message]
2012-01-11 19:29           ` KOSAKI Motohiro
2012-01-11 19:36             ` Pavel Emelyanov
2012-01-11 19:50               ` KOSAKI Motohiro
2012-01-11 19:57                 ` Pavel Emelyanov
2012-01-11 19:59             ` Cyrill Gorcunov
2012-01-11 20:19             ` Eric W. Biederman
2012-01-11 20:24               ` Pavel Emelyanov
2012-01-11 20:34                 ` Cyrill Gorcunov
2012-01-11 20:45                   ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120111183115.GA28196@moon \
    --to=gorcunov@gmail.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=avagin@openvz.org \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=eric.dumazet@gmail.com \
    --cc=glommer@parallels.com \
    --cc=herbert@gondor.hengli.com.au \
    --cc=kosaki.motohiro@gmail.com \
    --cc=kyle@moffetthome.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthltc@us.ibm.com \
    --cc=penberg@kernel.org \
    --cc=segoon@openwall.com \
    --cc=tj@kernel.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox