* [PATCH 1/2] regulator: s5m8767: Add missing breaks
@ 2012-01-12 6:57 Axel Lin
2012-01-12 6:58 ` [PATCH 2/2] regulator: s5m8767: Remove redundant MODULE_ALIAS Axel Lin
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Axel Lin @ 2012-01-12 6:57 UTC (permalink / raw)
To: linux-kernel; +Cc: Sangbeom Kim, Liam Girdwood, Mark Brown
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
This patch is against Mark's regulator tree (for-next-next branch).
drivers/regulator/s5m8767.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c
index b3d356f..4061012 100644
--- a/drivers/regulator/s5m8767.c
+++ b/drivers/regulator/s5m8767.c
@@ -742,15 +742,19 @@ static __devinit int s5m8767_pmic_probe(struct platform_device *pdev)
case 15:
s5m_reg_update(s5m8767->iodev, S5M8767_REG_DVSRAMP,
0xc0, 0xf0);
+ break;
case 25:
s5m_reg_update(s5m8767->iodev, S5M8767_REG_DVSRAMP,
0xd0, 0xf0);
+ break;
case 50:
s5m_reg_update(s5m8767->iodev, S5M8767_REG_DVSRAMP,
0xe0, 0xf0);
+ break;
case 100:
s5m_reg_update(s5m8767->iodev, S5M8767_REG_DVSRAMP,
0xf0, 0xf0);
+ break;
default:
s5m_reg_update(s5m8767->iodev, S5M8767_REG_DVSRAMP,
0x90, 0xf0);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] regulator: s5m8767: Remove redundant MODULE_ALIAS
2012-01-12 6:57 [PATCH 1/2] regulator: s5m8767: Add missing breaks Axel Lin
@ 2012-01-12 6:58 ` Axel Lin
2012-01-12 8:36 ` Sangbeom Kim
2012-01-12 8:29 ` [PATCH 1/2] regulator: s5m8767: Add missing breaks Sangbeom Kim
2012-01-12 8:42 ` Mark Brown
2 siblings, 1 reply; 6+ messages in thread
From: Axel Lin @ 2012-01-12 6:58 UTC (permalink / raw)
To: linux-kernel; +Cc: Sangbeom Kim, Liam Girdwood, Mark Brown
The MODULE_DEVICE_TABLE will setup the modalias, thus adding
a MODULE_ALIAS for an entry already in s5m8767_pmic_id is redundant.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/s5m8767.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c
index 4061012..caf0117 100644
--- a/drivers/regulator/s5m8767.c
+++ b/drivers/regulator/s5m8767.c
@@ -835,4 +835,3 @@ module_exit(s5m8767_pmic_exit);
MODULE_AUTHOR("Sangbeom Kim <sbkim73@samsung.com>");
MODULE_DESCRIPTION("SAMSUNG S5M8767 Regulator Driver");
MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:s5m8767-pmic");
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH 1/2] regulator: s5m8767: Add missing breaks
2012-01-12 6:57 [PATCH 1/2] regulator: s5m8767: Add missing breaks Axel Lin
2012-01-12 6:58 ` [PATCH 2/2] regulator: s5m8767: Remove redundant MODULE_ALIAS Axel Lin
@ 2012-01-12 8:29 ` Sangbeom Kim
2012-01-12 8:40 ` Mark Brown
2012-01-12 8:42 ` Mark Brown
2 siblings, 1 reply; 6+ messages in thread
From: Sangbeom Kim @ 2012-01-12 8:29 UTC (permalink / raw)
To: 'Axel Lin', linux-kernel
Cc: 'Liam Girdwood', 'Mark Brown'
On Thursday, January 12, 2012 3:57 PM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> This patch is against Mark's regulator tree (for-next-next branch).
>
> drivers/regulator/s5m8767.c | 4 ++++
During normal test, I can't detect the problem.
But It should add break to apply proper ramp slope.
Acked-by: Sangbeom Kim <sbkim73@samsung.com>
Thanks,
Sangbeom.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] regulator: s5m8767: Add missing breaks
2012-01-12 6:57 [PATCH 1/2] regulator: s5m8767: Add missing breaks Axel Lin
2012-01-12 6:58 ` [PATCH 2/2] regulator: s5m8767: Remove redundant MODULE_ALIAS Axel Lin
2012-01-12 8:29 ` [PATCH 1/2] regulator: s5m8767: Add missing breaks Sangbeom Kim
@ 2012-01-12 8:42 ` Mark Brown
2 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2012-01-12 8:42 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Sangbeom Kim, Liam Girdwood
On Thu, Jan 12, 2012 at 02:57:09PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied both, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-01-12 8:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-12 6:57 [PATCH 1/2] regulator: s5m8767: Add missing breaks Axel Lin
2012-01-12 6:58 ` [PATCH 2/2] regulator: s5m8767: Remove redundant MODULE_ALIAS Axel Lin
2012-01-12 8:36 ` Sangbeom Kim
2012-01-12 8:29 ` [PATCH 1/2] regulator: s5m8767: Add missing breaks Sangbeom Kim
2012-01-12 8:40 ` Mark Brown
2012-01-12 8:42 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox