From: Andrew Morton <akpm@linux-foundation.org>
To: Mandeep Singh Baines <msb@chromium.org>
Cc: Theodore Tso <tytso@google.com>, Greg KH <greg@kroah.com>,
Paul Taysom <taysom@chromium.org>,
Paul Taysom <taysom@google.com>,
Olof Johansson <olofj@chromium.org>, Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@google.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: Fix mod_timer crash when removing USB sticks
Date: Thu, 12 Jan 2012 15:23:03 -0800 [thread overview]
Message-ID: <20120112152303.420e723e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120112223544.GC18166@google.com>
On Thu, 12 Jan 2012 14:35:44 -0800
Mandeep Singh Baines <msb@chromium.org> wrote:
> Theodore Tso (tytso@google.com) wrote:
> > On Thu, Jan 12, 2012 at 4:53 PM, Mandeep Singh Baines <msb@chromium.org>wrote:
> >
> > >
> > > Hi Greg,
> > >
> > > What is the conventional way of doing this? There is a lot of good
> > > data in the bug report which might be useful to reviewers. We
> > > couldn't find a de-facto way of referencing the downstream bug database
> > > so we just made up a new field. Sorry. We'll use the correct
> > > field name next time.
> > >
> >
> > There isn't a "correct field name", since it hasn't been standardized. I
> > can tell you as an the ext4 maintainer, I've put things like
> >
> > Addresses-Redhat-Bugzilla: <Bugzilla #>
> >
> > or
> >
> > Addresses-Debian-Bug: <debian-bug-number>
> >
>
> This seems like a good convention. Its also nice in that it scales to
> the case where the bug is reported by multiple distros.
>
> For future, we'll use:
>
> Addresses-ChromiumOS-Bug: http://crosbug.com/<Bug #>
>
> I included the URL because its small and folks might not know where
> our bug database is.
I put "Addresses <some URL>" into the changelog. Just in the text body,
not as one of the tag:value pairs at the end of the changelog.
z:/usr/src/git26> git log | grep "Addresses http" | wc -l
121
next prev parent reply other threads:[~2012-01-12 23:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 21:15 [PATCH] fs: Fix mod_timer crash when removing USB sticks Paul Taysom
2012-01-12 21:38 ` Greg KH
2012-01-12 21:53 ` Mandeep Singh Baines
2012-01-12 22:02 ` Greg KH
2012-01-12 22:11 ` Theodore Tso
[not found] ` <CAGagf4dk4KsZSkaWTO9Yegi=_wRJsYBPgfyks1z=wMZJV8gX0w@mail.gmail.com>
2012-01-12 22:35 ` Mandeep Singh Baines
2012-01-12 23:23 ` Andrew Morton [this message]
2012-01-13 5:42 ` Josh Boyer
2012-01-13 15:39 ` Paul Taysom
-- strict thread matches above, loose matches on Subject: below --
2012-01-12 21:57 Paul Taysom
2012-03-16 17:36 ` Greg KH
2012-03-16 19:29 ` Paul Taysom
2012-03-16 19:43 ` Greg KH
2012-03-16 21:10 ` Theodore Tso
2012-03-17 0:06 ` Greg KH
2012-03-17 14:21 ` Alan Stern
2012-03-18 3:44 ` Ted Ts'o
2012-03-18 20:23 ` Alan Stern
2012-03-18 22:25 ` Mandeep Singh Baines
2012-03-20 0:24 ` Paul Taysom
2012-03-20 2:02 ` Alan Stern
2012-03-22 16:15 ` Paul Taysom
2012-01-12 19:57 Paul Taysom
2012-01-12 20:15 ` Greg KH
2012-01-13 11:28 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120112152303.420e723e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=akpm@google.com \
--cc=axboe@kernel.dk \
--cc=greg@kroah.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=msb@chromium.org \
--cc=olofj@chromium.org \
--cc=taysom@chromium.org \
--cc=taysom@google.com \
--cc=tytso@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox