From: Andrew Morton <akpm@linux-foundation.org>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Michael Hennerich <michael.hennerich@analog.com>,
Richard Purdie <rpurdie@rpsys.net>,
device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH] backlight: Fix the logic to set bits in adp8860_bl and adp8870_bl drivers
Date: Fri, 13 Jan 2012 14:10:19 -0800 [thread overview]
Message-ID: <20120113141019.1fc1439e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1326442521.5482.1.camel@phoenix>
On Fri, 13 Jan 2012 16:15:21 +0800
Axel Lin <axel.lin@gmail.com> wrote:
> We need to write new value if the bit mask fields of new value is not equal to
> old value. It does not make sense to write new value only when all the bit_mask
> bits are zero.
When fixing bugs, please always describe the user-visible effects of
the bug.
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index 66bc74d..378276c 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -146,7 +146,7 @@ static int adp8860_set_bits(struct i2c_client *client, int reg, uint8_t bit_mask
>
> ret = adp8860_read(client, reg, ®_val);
>
> - if (!ret && ((reg_val & bit_mask) == 0)) {
> + if (!ret && ((reg_val & bit_mask) != bit_mask)) {
> reg_val |= bit_mask;
> ret = adp8860_write(client, reg, reg_val);
> }
> diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
> index 6c68a68..6735059 100644
> --- a/drivers/video/backlight/adp8870_bl.c
> +++ b/drivers/video/backlight/adp8870_bl.c
> @@ -160,7 +160,7 @@ static int adp8870_set_bits(struct i2c_client *client, int reg, uint8_t bit_mask
>
> ret = adp8870_read(client, reg, ®_val);
>
> - if (!ret && ((reg_val & bit_mask) == 0)) {
> + if (!ret && ((reg_val & bit_mask) != bit_mask)) {
> reg_val |= bit_mask;
> ret = adp8870_write(client, reg, reg_val);
> }
This patch is applicable to 3.2.x, but I don't know whether to route it
to -stable becasue you didn't tell me what effect the patch has :(
next prev parent reply other threads:[~2012-01-13 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 8:15 [PATCH] backlight: Fix the logic to set bits in adp8860_bl and adp8870_bl drivers Axel Lin
2012-01-13 22:10 ` Andrew Morton [this message]
2012-01-14 9:22 ` Axel Lin
2012-01-16 8:33 ` Hennerich, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113141019.1fc1439e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox