* [PATCH] drivers/net/usb/smsc95xx.c: change msleep() to usleep_range()
@ 2012-01-13 11:57 Dmitry Antipov
2012-01-13 18:11 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Antipov @ 2012-01-13 11:57 UTC (permalink / raw)
To: Steve Glendinning
Cc: Greg Kroah-Hartman, linux-usb, linux-kernel, Dmitry Antipov
The resolution of msleep is related to HZ, so 10ms msleep() causes
~23ms sleep with OMAP's default CONFIG_HZ=128 timer configuration.
This looks too much, and usleep_range() with some slack gives more
control of what is happening here.
Signed-off-by: Dmitry Antipov <dmitry.antipov@linaro.org>
---
drivers/net/usb/smsc95xx.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index d45520e..5d406d4 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -688,7 +688,7 @@ static int smsc95xx_phy_initialize(struct usbnet *dev)
smsc95xx_mdio_write(dev->net, dev->mii.phy_id, MII_BMCR, BMCR_RESET);
do {
- msleep(10);
+ usleep_range(10000, 15000);
bmcr = smsc95xx_mdio_read(dev->net, dev->mii.phy_id, MII_BMCR);
timeout++;
} while ((bmcr & BMCR_RESET) && (timeout < 100));
@@ -736,7 +736,7 @@ static int smsc95xx_reset(struct usbnet *dev)
netdev_warn(dev->net, "Failed to read HW_CFG: %d\n", ret);
return ret;
}
- msleep(10);
+ usleep_range(10000, 15000);
timeout++;
} while ((read_buf & HW_CFG_LRST_) && (timeout < 100));
@@ -759,7 +759,7 @@ static int smsc95xx_reset(struct usbnet *dev)
netdev_warn(dev->net, "Failed to read PM_CTRL: %d\n", ret);
return ret;
}
- msleep(10);
+ usleep_range(10000, 15000);
timeout++;
} while ((read_buf & PM_CTL_PHY_RST_) && (timeout < 100));
--
1.7.7.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/net/usb/smsc95xx.c: change msleep() to usleep_range()
2012-01-13 11:57 [PATCH] drivers/net/usb/smsc95xx.c: change msleep() to usleep_range() Dmitry Antipov
@ 2012-01-13 18:11 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2012-01-13 18:11 UTC (permalink / raw)
To: Dmitry Antipov
Cc: Steve Glendinning, Greg Kroah-Hartman, linux-usb, linux-kernel
On Fri, Jan 13, 2012 at 03:57:04PM +0400, Dmitry Antipov wrote:
> The resolution of msleep is related to HZ, so 10ms msleep() causes
> ~23ms sleep with OMAP's default CONFIG_HZ=128 timer configuration.
> This looks too much, and usleep_range() with some slack gives more
> control of what is happening here.
>
> Signed-off-by: Dmitry Antipov <dmitry.antipov@linaro.org>
> ---
> drivers/net/usb/smsc95xx.c | 6 +++---
drivers/net/* patches need to be sent to netdev@vger.kernel.org to be
properly applied.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-13 18:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-13 11:57 [PATCH] drivers/net/usb/smsc95xx.c: change msleep() to usleep_range() Dmitry Antipov
2012-01-13 18:11 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox