From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Alex Rio <scasbyte@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH 1/2] hwmon: (w83627ehf) Replace deprecated strict_strto*
Date: Sat, 14 Jan 2012 09:46:07 -0800 [thread overview]
Message-ID: <20120114174607.GE29012@ericsson.com> (raw)
In-Reply-To: <20120114184445.3871e019@endymion.delvare>
On Sat, Jan 14, 2012 at 12:44:45PM -0500, Jean Delvare wrote:
> On Sat, 14 Jan 2012 09:25:38 -0800, Guenter Roeck wrote:
> > On Fri, Jan 13, 2012 at 08:39:41PM -0500, Alex Rio wrote:
> > > Replaces deprecated function strict_strto* to kstrto*. In the future
> > > the strict_strto could disappear so the replacement was done.
> > > I'm not sure if this is being done for all the files in a single
> > > patch, anyway I'm including it here just in case.
> > > Checkpatch.pl now leaves 5 "errors", they are mostly
> > > assignments inside if's statements, taking them out does not
> > > significantly increases readability.
> > >
> > > Signed-off-by: Alex Rio <scasbyte@gmail.com>
> >
> > Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
> >
> > Jean, do you want to take this one ? Otherwise, I'll add it to my pending list
> > for the next -rc.
>
> Err, I'm confused... Aren't these changes already upstream?
>
Yes, you are right. Sorry for the noise.
Guenter
prev parent reply other threads:[~2012-01-14 17:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-14 1:39 [RFC][PATCH 1/2] hwmon: (w83627ehf) Replace deprecated strict_strto* Alex Rio
2012-01-14 17:25 ` Guenter Roeck
2012-01-14 17:44 ` Jean Delvare
2012-01-14 17:46 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120114174607.GE29012@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scasbyte@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox