From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756021Ab2ANRrx (ORCPT ); Sat, 14 Jan 2012 12:47:53 -0500 Received: from imr4.ericy.com ([198.24.6.9]:56629 "EHLO imr4.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755928Ab2ANRrw (ORCPT ); Sat, 14 Jan 2012 12:47:52 -0500 Date: Sat, 14 Jan 2012 09:46:07 -0800 From: Guenter Roeck To: Jean Delvare CC: Alex Rio , "linux-kernel@vger.kernel.org" Subject: Re: [RFC][PATCH 1/2] hwmon: (w83627ehf) Replace deprecated strict_strto* Message-ID: <20120114174607.GE29012@ericsson.com> References: <20120114172538.GD29012@ericsson.com> <20120114184445.3871e019@endymion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20120114184445.3871e019@endymion.delvare> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 14, 2012 at 12:44:45PM -0500, Jean Delvare wrote: > On Sat, 14 Jan 2012 09:25:38 -0800, Guenter Roeck wrote: > > On Fri, Jan 13, 2012 at 08:39:41PM -0500, Alex Rio wrote: > > > Replaces deprecated function strict_strto* to kstrto*. In the future > > > the strict_strto could disappear so the replacement was done. > > > I'm not sure if this is being done for all the files in a single > > > patch, anyway I'm including it here just in case. > > > Checkpatch.pl now leaves 5 "errors", they are mostly > > > assignments inside if's statements, taking them out does not > > > significantly increases readability. > > > > > > Signed-off-by: Alex Rio > > > > Acked-by: Guenter Roeck > > > > Jean, do you want to take this one ? Otherwise, I'll add it to my pending list > > for the next -rc. > > Err, I'm confused... Aren't these changes already upstream? > Yes, you are right. Sorry for the noise. Guenter