[PULL REQUEST] More UBI/UBIFS changes for 3.3

[PULL REQUEST] More UBI/UBIFS changes for 3.3

[Bityutskiy, Artem]

[-- Attachment #1.1: Type: text/plain, Size: 1078 bytes --]

Hi Linus,

please pull more UBI/UBIFS changes for 3.3, thanks!

The following changes since commit 805a6af8dba5dfdd35ec35dc52ec0122400b2610:

  Linux 3.2 (2012-01-04 15:55:44 -0800)

are available in the git repository at:
  git://git.infradead.org/ubifs-2.6.git linux-next

Artem Bityutskiy (5):
      UBI: fix debugging messages
      UBIFS: make debugging messages light again
      UBIFS: fix debugging messages
      UBIFS: use snprintf instead of sprintf when printing keys
      UBIFS: fix key printing

Richard Weinberger (1):
      UBI: make vid_hdr non-static

 drivers/mtd/ubi/debug.h |    5 ++-
 drivers/mtd/ubi/vtbl.c  |    2 +-
 fs/ubifs/debug.c        |   90 ++++++++++++++++++++++++-----------------------
 fs/ubifs/debug.h        |   44 +++++++++++++----------
 fs/ubifs/journal.c      |    7 ++--
 fs/ubifs/replay.c       |    8 ++--
 fs/ubifs/tnc.c          |   55 ++++++++++++++--------------
 fs/ubifs/tnc_misc.c     |   10 +++---
 8 files changed, 115 insertions(+), 106 deletions(-)

-- 
Best Regards,
Artem Bityutskiy


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 464 bytes --]

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Re: [PULL REQUEST] More UBI/UBIFS changes for 3.3

[Dave Jones]

On Fri, Jan 13, 2012 at 12:11:57PM +0000, Bityutskiy, Artem wrote:
 > Hi Linus,
 > 
 > please pull more UBI/UBIFS changes for 3.3, thanks!
 > 
 > The following changes since commit 805a6af8dba5dfdd35ec35dc52ec0122400b2610:
 > 
 >   Linux 3.2 (2012-01-04 15:55:44 -0800)

This introduced a compile failure if CONFIG_UBIFS_FS_DEBUG is unset.

fs/ubifs/journal.c: In function ‘ubifs_jnl_write_data’:
fs/ubifs/journal.c:700:2: error: implicit declaration of function ‘dbg_jnlk’ [-Werror=implicit-function-declaration]

	Dave

Re: [PULL REQUEST] More UBI/UBIFS changes for 3.3

[Anca Emanuel]

On Sat, Jan 14, 2012 at 8:48 PM, Dave Jones <davej@redhat.com> wrote:

> This introduced a compile failure if CONFIG_UBIFS_FS_DEBUG is unset.
>
> fs/ubifs/journal.c: In function ‘ubifs_jnl_write_data’:
> fs/ubifs/journal.c:700:2: error: implicit declaration of function ‘dbg_jnlk’ [-Werror=implicit-function-declaration]

And now it is in Linus tree.


  CC [M]  fs/ubifs/journal.o
fs/ubifs/journal.c: In function ‘ubifs_jnl_write_data’:
fs/ubifs/journal.c:700:2: error: implicit declaration of function
‘dbg_jnlk’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

make[3]: *** [fs/ubifs/journal.o] Error 1
make[2]: *** [fs/ubifs] Error 2
make[1]: *** [fs] Error 2

Re: [PULL REQUEST] More UBI/UBIFS changes for 3.3

[Artem Bityutskiy]

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

On Sun, 2012-01-15 at 11:19 +0200, Anca Emanuel wrote:
> On Sat, Jan 14, 2012 at 8:48 PM, Dave Jones <davej@redhat.com> wrote:
> 
> > This introduced a compile failure if CONFIG_UBIFS_FS_DEBUG is unset.
> >
> > fs/ubifs/journal.c: In function ‘ubifs_jnl_write_data’:
> > fs/ubifs/journal.c:700:2: error: implicit declaration of function ‘dbg_jnlk’ [-Werror=implicit-function-declaration]
> 
> And now it is in Linus tree.

Sorry for this, I've sent today another pull request with a fix. I was
not careful enough to test UBIFS when debugging is disabled.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]