* [PATCH] mfd: variable dereferenced before check
@ 2012-01-13 1:40 jhbird.choi
2012-01-15 11:15 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: jhbird.choi @ 2012-01-13 1:40 UTC (permalink / raw)
To: linux-kernel; +Cc: Mark Brown, Liam Girdwood, Jonghwan Choi
From: Jonghwan Choi <jhbird.choi@samsung.com>
Remove "wm8350->irq_base = pdata->irq_base" to avoid
null pointer exception and wm8350->irq_base got from
irq_alloc_descs().
Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
drivers/mfd/wm8350-irq.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/wm8350-irq.c b/drivers/mfd/wm8350-irq.c
index 8a1fafd..9fd01bf 100644
--- a/drivers/mfd/wm8350-irq.c
+++ b/drivers/mfd/wm8350-irq.c
@@ -496,7 +496,6 @@ int wm8350_irq_init(struct wm8350 *wm8350, int irq,
mutex_init(&wm8350->irq_lock);
wm8350->chip_irq = irq;
- wm8350->irq_base = pdata->irq_base;
if (pdata && pdata->irq_base > 0)
irq_base = pdata->irq_base;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: variable dereferenced before check
2012-01-13 1:40 [PATCH] mfd: variable dereferenced before check jhbird.choi
@ 2012-01-15 11:15 ` Mark Brown
2012-02-20 15:15 ` Samuel Ortiz
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2012-01-15 11:15 UTC (permalink / raw)
To: jhbird.choi, Samuel Ortiz; +Cc: linux-kernel, Liam Girdwood
On Fri, Jan 13, 2012 at 10:40:52AM +0900, jhbird.choi@samsung.com wrote:
> From: Jonghwan Choi <jhbird.choi@samsung.com>
>
> Remove "wm8350->irq_base = pdata->irq_base" to avoid
> null pointer exception and wm8350->irq_base got from
> irq_alloc_descs().
Always send patches to the relevant maintainers - for the MFD subsystem
the maintainer is Samuel Ortiz.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
> ---
> drivers/mfd/wm8350-irq.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/wm8350-irq.c b/drivers/mfd/wm8350-irq.c
> index 8a1fafd..9fd01bf 100644
> --- a/drivers/mfd/wm8350-irq.c
> +++ b/drivers/mfd/wm8350-irq.c
> @@ -496,7 +496,6 @@ int wm8350_irq_init(struct wm8350 *wm8350, int irq,
>
> mutex_init(&wm8350->irq_lock);
> wm8350->chip_irq = irq;
> - wm8350->irq_base = pdata->irq_base;
>
> if (pdata && pdata->irq_base > 0)
> irq_base = pdata->irq_base;
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: variable dereferenced before check
2012-01-15 11:15 ` Mark Brown
@ 2012-02-20 15:15 ` Samuel Ortiz
0 siblings, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2012-02-20 15:15 UTC (permalink / raw)
To: Mark Brown; +Cc: jhbird.choi, linux-kernel, Liam Girdwood
Hi Mark,
On Sun, Jan 15, 2012 at 03:15:55AM -0800, Mark Brown wrote:
> On Fri, Jan 13, 2012 at 10:40:52AM +0900, jhbird.choi@samsung.com wrote:
> > From: Jonghwan Choi <jhbird.choi@samsung.com>
> >
> > Remove "wm8350->irq_base = pdata->irq_base" to avoid
> > null pointer exception and wm8350->irq_base got from
> > irq_alloc_descs().
>
> Always send patches to the relevant maintainers - for the MFD subsystem
> the maintainer is Samuel Ortiz.
Thanks for the notification. Patch applied now.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-20 15:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-13 1:40 [PATCH] mfd: variable dereferenced before check jhbird.choi
2012-01-15 11:15 ` Mark Brown
2012-02-20 15:15 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox