Re: [PATCH 1/4] staging/xgifb: Remove unsupported mode LCD_320x480

[Dan Carpenter <dan.carpenter@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

On Sun, Jan 15, 2012 at 07:22:10PM +0100, Peter Huewe wrote:
> This patch removes the probed mode LCD_320x480 which isn't supported
> anyway since this mode falls through to the default (=invalid) mode in the
> XGIfb_validate_mode function (see line 529 ff. for details).
> 
> By removing this assignment, we can use the LCD_TYPEs from the sis
> driver without modifications.
> 
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
>  drivers/staging/xgifb/XGI_main_26.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> index 2502c49..c27dbf8 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -2118,10 +2118,13 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
>  			reg &= 0x0f;
>  			hw_info->ulCRT2LCDType = XGI310paneltype[reg];
>  
> -		} else {
> +		}
> +		#if 0

Uh...  Why not just delete this code and the code in
XGIfb_validate_mode() as well?

regards,
dan carepenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]