linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: Keith Packard <keithp@keithp.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.de>,
	Michal Marek <mmarek@suse.com>,
	"intel-gfx@lists.freedesktop..."
	<intel-gfx@lists.freedesktop.org>,
	Robert Lemaire <rlemaire@suse.com>
Subject: Re: [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort
Date: Mon, 16 Jan 2012 16:02:53 +0800	[thread overview]
Message-ID: <20120116080252.GA18538@localhost> (raw)
In-Reply-To: <86ty404yhd.fsf@sumi.keithp.com>

On Thu, Jan 12, 2012 at 09:33:34AM -0800, Keith Packard wrote:
> On Tue, 10 Jan 2012 13:45:19 +0800, Wu Fengguang <fengguang.wu@intel.com> wrote:
> 
> > @@ -5943,6 +5947,7 @@ static void ironlake_write_eld(struct dr
> >  	if (intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT)) {
> >  		DRM_DEBUG_DRIVER("ELD: DisplayPort detected\n");
> >  		eld[5] |= (1 << 2);	/* Conn_Type, 0x1 = DisplayPort */
> > +		I915_WRITE(aud_config, AUD_CONFIG_N_VALUE_INDEX); /* 0x1 = DP */
> >  	}
> 
> Do we need to clear this bit in the HDMI case? Or do we just trust the
> BIOS to either leave this bit zero or set it correctly?

I tried booting

1) with HDMI monitor plugged
2) plug HDMI monitor after BIOS boot

In both cases, I get the same AUD_CONFIG values for the host/sink matrix

                RX-V1800        SONY TV
ivybridge       0x00000000      0x00000000
ironlake        0x00000000      0x00000000

HDMI audio is working fine in all cases. So I guess it's fine to leave
HDMI as (unconfigured) 0.

Thanks,
Fengguang

  reply	other threads:[~2012-01-16  8:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-09 13:17 [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort Wu Fengguang
2012-01-09 17:22 ` Keith Packard
2012-01-10  5:45   ` Wu Fengguang
2012-01-12 17:33     ` Keith Packard
2012-01-16  8:02       ` Wu Fengguang [this message]
2012-01-16 20:26         ` [Intel-gfx] " Daniel Vetter
2012-01-16 20:44           ` Keith Packard
2012-01-16 23:08             ` Wu Fengguang
2012-01-16 23:15               ` Keith Packard
2012-01-17 10:22               ` Daniel Vetter
2012-01-29  4:44                 ` [PATCH][rebased] " Wu Fengguang
2012-01-29 12:12                   ` Daniel Vetter
2012-01-29 13:23                     ` Wu Fengguang
2012-01-29 15:14                       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120116080252.GA18538@localhost \
    --to=fengguang.wu@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=keithp@keithp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=rlemaire@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).