From: Ingo Molnar <mingo@elte.hu>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: Update scheduler stat documentation.
Date: Mon, 16 Jan 2012 09:36:15 +0100 [thread overview]
Message-ID: <20120116083615.GB23622@elte.hu> (raw)
In-Reply-To: <CADZ9YHjxuqJ2YpEonqXjRsJZGsihy7ao_cA-NRwXoOM1KF3Tpw@mail.gmail.com>
* Rakib Mullick <rakib.mullick@gmail.com> wrote:
> On Mon, Jan 16, 2012 at 1:56 PM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Rakib Mullick <rakib.mullick@gmail.com> wrote:
> >
> >> /proc/schedstat's second field reflect to # of time context switch happened not # of times switched to the expired queue.
> >>
> >> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
> >> ---
> >>
> >> diff --git a/Documentation/scheduler/sched-stats.txt b/Documentation/scheduler/sched-stats.txt
> >> index 1cd5d51..7d8e12c 100644
> >> --- a/Documentation/scheduler/sched-stats.txt
> >> +++ b/Documentation/scheduler/sched-stats.txt
> >> @@ -38,7 +38,8 @@ First field is a sched_yield() statistic:
> >> 1) # of times sched_yield() was called
> >>
> >> Next three are schedule() statistics:
> >> - 2) # of times we switched to the expired queue and reused it
> >> + 2) # of times context switch happened. This field is not utilized these
> >> + days but kept for holding userspace tools integrity.
> >
> > if it's not used by anything but kept for the ABI then we should
> > not put context switch number in there, but always keep it zero,
> > right?
> >
>
> Yes, quite right. It is a bit confusing. Anyone might have
> think that context switch numbers are 0. So, instead of saying
> "# of times context switch happened", we can say, "This field
> has been kept for ABI integrity". Right?
Yes - but we should also change it to export a value of zero.
The field is a legacy 'array expirations' field, and as such it
should be zero.
Thanks,
Ingo
next prev parent reply other threads:[~2012-01-16 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 17:27 [PATCH] sched: Update scheduler stat documentation Rakib Mullick
2012-01-16 7:56 ` Ingo Molnar
2012-01-16 8:22 ` Rakib Mullick
2012-01-16 8:36 ` Ingo Molnar [this message]
2012-01-16 16:51 ` Rakib Mullick
2012-01-17 9:50 ` Ingo Molnar
2012-01-17 15:33 ` Rakib Mullick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120116083615.GB23622@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox