From: Greg Kroah-Hartman <greg@kroah.com>
To: James Bottomley <jbottomley@parallels.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Parisc List <linux-parisc@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Fix compile breakage with kref.h
Date: Tue, 17 Jan 2012 13:26:39 -0800 [thread overview]
Message-ID: <20120117212639.GA17297@kroah.com> (raw)
In-Reply-To: <1326834845.3020.36.camel@dabdike>
On Tue, Jan 17, 2012 at 09:14:05PM +0000, James Bottomley wrote:
> This set of build failures just started appearing on parisc:
>
> In file included from drivers/input/serio/serio_raw.c:12:
> include/linux/kref.h: In function 'kref_get':
> include/linux/kref.h:40: error: 'TAINT_WARN' undeclared (first use in this function)
> include/linux/kref.h:40: error: (Each undeclared identifier is reported only once
> include/linux/kref.h:40: error: for each function it appears in.)
> include/linux/kref.h: In function 'kref_sub':
> include/linux/kref.h:65: error: 'TAINT_WARN' undeclared (first use in this function)
>
> It happens because TAINT_WARN is defined in kernel.h and this particular
> compile doesn't seem to include it (no idea why it's just
> manifesting ... probably some #include file untangling exposed it). Fix
> by adding #include <linux/kernel.h> to linux/kref.h
Does adding <linux/bug.h> fix it instead? We are using WARN_ON() here.
Hm, but that needs kernel.h as well, ugh, what a mess.
> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
next prev parent reply other threads:[~2012-01-17 21:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 21:14 Fix compile breakage with kref.h James Bottomley
2012-01-17 21:26 ` Greg Kroah-Hartman [this message]
2012-01-17 22:09 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117212639.GA17297@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox