[PATCH] pch_phub: add message to notify installing pch_phub

[PATCH] pch_phub: add message to notify installing pch_phub

[Tomoya MORINAGA]

Currently, a user who wants to install pch_phub, the user can't know whether
the driver is installed or not from log of kernel ring buffer.
Of course, though seeing sysfs files, the user can know the installing,
kernel message is useful better than seeing sysfs files.

So, this patch adds logs.

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
---
 drivers/misc/pch_phub.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/misc/pch_phub.c b/drivers/misc/pch_phub.c
index 10fc478..c2beb13 100644
--- a/drivers/misc/pch_phub.c
+++ b/drivers/misc/pch_phub.c
@@ -746,6 +746,7 @@ static int __devinit pch_phub_probe(struct pci_dev *pdev,
 		iowrite32(0x25, chip->pch_phub_base_address + 0x44);
 		chip->pch_opt_rom_start_address = PCH_PHUB_ROM_START_ADDR_EG20T;
 		chip->pch_mac_start_address = PCH_PHUB_MAC_START_ADDR_EG20T;
+		dev_info(&pdev->dev, "Intel EG20T PCH PacketHub\n");
 	} else if (id->driver_data == 2) { /* ML7213 IOH */
 		retval = sysfs_create_bin_file(&pdev->dev.kobj, &pch_bin_attr);
 		if (retval)
@@ -759,6 +760,7 @@ static int __devinit pch_phub_probe(struct pci_dev *pdev,
 		iowrite32(0x000affa0, chip->pch_phub_base_address + 0x14);
 		chip->pch_opt_rom_start_address =\
 						 PCH_PHUB_ROM_START_ADDR_ML7213;
+		dev_info(&pdev->dev, "LAPIS Semiconductor ML7213 PacketHub\n");
 	} else if (id->driver_data == 3) { /* ML7223 IOH Bus-m*/
 		/* set the prefech value
 		 * Device8(GbE)
@@ -769,6 +771,8 @@ static int __devinit pch_phub_probe(struct pci_dev *pdev,
 		chip->pch_opt_rom_start_address =\
 						 PCH_PHUB_ROM_START_ADDR_ML7223;
 		chip->pch_mac_start_address = PCH_PHUB_MAC_START_ADDR_ML7223;
+		dev_info(&pdev->dev,
+			 "LAPIS Semiconductor ML7223[Bus-m] PacketHub\n");
 	} else if (id->driver_data == 4) { /* ML7223 IOH Bus-n*/
 		retval = sysfs_create_file(&pdev->dev.kobj,
 					   &dev_attr_pch_mac.attr);
@@ -786,6 +790,8 @@ static int __devinit pch_phub_probe(struct pci_dev *pdev,
 		chip->pch_opt_rom_start_address =\
 						 PCH_PHUB_ROM_START_ADDR_ML7223;
 		chip->pch_mac_start_address = PCH_PHUB_MAC_START_ADDR_ML7223;
+		dev_info(&pdev->dev,
+			 "LAPIS Semiconductor ML7223[Bus-n] PacketHub\n");
 	} else if (id->driver_data == 5) { /* ML7831 */
 		retval = sysfs_create_file(&pdev->dev.kobj,
 					   &dev_attr_pch_mac.attr);
@@ -802,6 +808,7 @@ static int __devinit pch_phub_probe(struct pci_dev *pdev,
 		iowrite32(0x25, chip->pch_phub_base_address + 0x44);
 		chip->pch_opt_rom_start_address = PCH_PHUB_ROM_START_ADDR_EG20T;
 		chip->pch_mac_start_address = PCH_PHUB_MAC_START_ADDR_EG20T;
+		dev_info(&pdev->dev, "LAPIS Semiconductor ML7831 PacketHub\n");
 	}
 
 	chip->ioh_type = id->driver_data;
-- 
1.7.4.4

Re: [PATCH] pch_phub: add message to notify installing pch_phub

[Greg KH]

On Thu, Jan 19, 2012 at 10:07:47AM +0900, Tomoya MORINAGA wrote:
> Currently, a user who wants to install pch_phub, the user can't know whether
> the driver is installed or not from log of kernel ring buffer.
> Of course, though seeing sysfs files, the user can know the installing,
> kernel message is useful better than seeing sysfs files.
> 
> So, this patch adds logs.

No, I'm going to reject this, we have been _removing_ these types of
garbage messages from drivers, please don't add new ones, it is
pointless.

greg k-h

Re: [PATCH] pch_phub: add message to notify installing pch_phub

[Tomoya MORINAGA]

2012/1/19 Greg KH <gregkh@suse.de>:
> No, I'm going to reject this, we have been _removing_ these types of
> garbage messages from drivers, please don't add new ones, it is
> pointless.
>

You mean you can't allow only one-line driver installed message ?
If yes, let me know your opinion about below.
How users can know the driver is installed or not ?

thanks,
tomoya

Re: [PATCH] pch_phub: add message to notify installing pch_phub

[Greg KH]

On Thu, Jan 19, 2012 at 11:22:24AM +0900, Tomoya MORINAGA wrote:
> 2012/1/19 Greg KH <gregkh@suse.de>:
> > No, I'm going to reject this, we have been _removing_ these types of
> > garbage messages from drivers, please don't add new ones, it is
> > pointless.
> >
> 
> You mean you can't allow only one-line driver installed message ?

Nope, why are they needed, they are wasted space and time.

> If yes, let me know your opinion about below.
> How users can know the driver is installed or not ?

They use the device and it works?

That's all that is really needed, right? :)

If that doesn't work, they can look in the module list, or in sysfs,
like you said people already do today.  But why would they need to look,
your driver should be automatically loaded already, no user should ever
care about loading it.

thanks,

greg k-h

Re: [PATCH] pch_phub: add message to notify installing pch_phub

[Tomoya MORINAGA]

2012/1/19 Greg KH <gregkh@suse.de>:
> On Thu, Jan 19, 2012 at 11:22:24AM +0900, Tomoya MORINAGA wrote:
>> 2012/1/19 Greg KH <gregkh@suse.de>:
>> > No, I'm going to reject this, we have been _removing_ these types of
>> > garbage messages from drivers, please don't add new ones, it is
>> > pointless.
>> >
>>
>> You mean you can't allow only one-line driver installed message ?
>
> Nope, why are they needed, they are wasted space and time.
>
>> If yes, let me know your opinion about below.
>> How users can know the driver is installed or not ?
>
> They use the device and it works?
>
> That's all that is really needed, right? :)
>
> If that doesn't work, they can look in the module list, or in sysfs,
> like you said people already do today.  But why would they need to look,
> your driver should be automatically loaded already, no user should ever
> care about loading it.

OK.
I could agree with your opinion.

thanks, tomoya