Re: [patch]block: fix NULL icq_cache reference

[Tejun Heo <tj@kernel.org>]

Hello,

On Thu, Jan 19, 2012 at 09:41:34AM +0800, Shaohua Li wrote:
> > Hmmm... but I'm having a difficult time following the description.
> > Maybe we can simplify a bit?  e.g. sth like the following?
> > 
> >   Once a queue is quiesced, it's not supposed to have any elvpriv data
> >   or icq's, and elevator switching depends on that.  Request alloc
> >   path followed the rule for elvpriv data but forgot apply it to
> >   icq's leading to the following crash during elevator switch.
> > 
> >   <oops log>
> > 
> >   Fix it by not allocating icq's if ELVPRIV is not set for the
> >   request.
>
> I'm trying to explain why there is a crash, but fine to use your
> description.

Yeah, giving details is great.  It just seemed that high level
description seemed lost among the details.  It would have been great
if the description started with high level description and then went
into details.

> Once a queue is quiesced, it's not supposed to have any elvpriv data or
> icq's, and elevator switching depends on that.  Request alloc path
> followed the rule for elvpriv data but forgot apply it to icq's
> leading to the following crash during elevator switch. Fix it by not
> allocating icq's if ELVPRIV is not set for the request.
> 
> Reported-by: Vivek Goyal <vgoyal@redhat.com>
> Tested-by: Vivek Goyal <vgoyal@redhat.com>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks a lot.

-- 
tejun