From: Greg KH <gregkh@suse.de>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexander Stein <alexander.stein@systec-electronic.com>,
Denis Turischev <denis@compulab.co.il>,
linux-kernel@vger.kernel.org, qi.wang@intel.com,
yong.y.wang@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com
Subject: Re: [PATCH] pch_phub: add message to notify installing pch_phub
Date: Wed, 18 Jan 2012 22:50:53 -0800 [thread overview]
Message-ID: <20120119065053.GB7270@suse.de> (raw)
In-Reply-To: <CANKRQnikxUjtUjnKZ=GkV1kLUVx_N2ipSr86PiJrm=iZq_Mhaw@mail.gmail.com>
On Thu, Jan 19, 2012 at 11:22:24AM +0900, Tomoya MORINAGA wrote:
> 2012/1/19 Greg KH <gregkh@suse.de>:
> > No, I'm going to reject this, we have been _removing_ these types of
> > garbage messages from drivers, please don't add new ones, it is
> > pointless.
> >
>
> You mean you can't allow only one-line driver installed message ?
Nope, why are they needed, they are wasted space and time.
> If yes, let me know your opinion about below.
> How users can know the driver is installed or not ?
They use the device and it works?
That's all that is really needed, right? :)
If that doesn't work, they can look in the module list, or in sysfs,
like you said people already do today. But why would they need to look,
your driver should be automatically loaded already, no user should ever
care about loading it.
thanks,
greg k-h
next prev parent reply other threads:[~2012-01-19 7:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 1:07 [PATCH] pch_phub: add message to notify installing pch_phub Tomoya MORINAGA
2012-01-19 1:21 ` Greg KH
2012-01-19 2:22 ` Tomoya MORINAGA
2012-01-19 6:50 ` Greg KH [this message]
2012-01-19 8:01 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119065053.GB7270@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alexander.stein@systec-electronic.com \
--cc=denis@compulab.co.il \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=tomoya.rohm@gmail.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox