From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754426Ab2ASKkg (ORCPT ); Thu, 19 Jan 2012 05:40:36 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:53238 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752083Ab2ASKkc (ORCPT ); Thu, 19 Jan 2012 05:40:32 -0500 Date: Thu, 19 Jan 2012 10:40:30 +0000 From: Mark Brown To: Laxman Dewangan Cc: Stephen Warren , "lrg@ti.com" , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH V1 2/2] regulator: tps65910: Initialize n_voltages for rails. Message-ID: <20120119104029.GA3178@opensource.wolfsonmicro.com> References: <1326899836-14470-1-git-send-email-ldewangan@nvidia.com> <74CDBE0F657A3D45AFBB94109FB122FF1780DAAE10@HQMAIL01.nvidia.com> <20120118175613.GT8732@opensource.wolfsonmicro.com> <96C9D994977DD0439FB6D3FE3B13DD907DC3DCC1C3@BGMAIL01.nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <96C9D994977DD0439FB6D3FE3B13DD907DC3DCC1C3@BGMAIL01.nvidia.com> X-Cookie: Your present plans will be successful. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2012 at 08:54:19AM +0530, Laxman Dewangan wrote: > Do you want to rename the variable in this patch or in separate patch? > In place of table_len, I will say n_voltages as this is most common name > in regulator world. Probably two is clearer, though if it's not set already for any of the regulators just one should be fine.