From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
"Igor M. Liplianin" <liplianin@me.by>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] [media] ds3000: off by one in ds3000_read_snr()
Date: Thu, 19 Jan 2012 15:22:02 +0300 [thread overview]
Message-ID: <20120119122202.GJ3294@mwanda> (raw)
In-Reply-To: <4F17EFE1.3060804@bfs.de>
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
On Thu, Jan 19, 2012 at 11:26:41AM +0100, walter harms wrote:
> >> perhaps it is more useful to do it in the check above ?
> >
> > It looks like the check is correct but we need to shift all the
> > values by one. Again, I don't have this hardware, I'm just going by
> > the context.
> >
> I do not have the hardware either so this is pure theoretical.
>
> Access to the data field depends on the value of dvbs2_noise_reading/tmp
> even when the data are reasonable like 50/100 snr_reading would become 0
> and the index suddenly is -1.
>
It's a good point. I will redo the patch.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-19 12:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 7:30 [patch 2/2] [media] ds3000: off by one in ds3000_read_snr() Dan Carpenter
2012-01-18 17:06 ` walter harms
2012-01-19 9:33 ` Dan Carpenter
2012-01-19 10:26 ` walter harms
2012-01-19 12:22 ` Dan Carpenter [this message]
2012-01-21 15:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119122202.GJ3294@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=liplianin@me.by \
--cc=mchehab@infradead.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox