From: Oleg Nesterov <oleg@redhat.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Emelyanov <xemul@parallels.com>,
Serge Hallyn <serge.hallyn@canonical.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Tejun Heo <tj@kernel.org>, Andrew Vagin <avagin@openvz.org>,
Vasiliy Kulikov <segoon@openwall.com>
Subject: Re: [RFC] fs, proc: Introduce /proc/<pid>/task/<tid>/children entry v6
Date: Thu, 19 Jan 2012 17:44:13 +0100 [thread overview]
Message-ID: <20120119164413.GA16522@redhat.com> (raw)
In-Reply-To: <20120119162718.GA32568@moon>
On 01/19, Cyrill Gorcunov wrote:
>
> On Thu, Jan 19, 2012 at 04:55:29PM +0100, Oleg Nesterov wrote:
> >
> > Thinking more... I am not sure, but do we really need
> > proc_pid_children_iter at all??
> >
> > It is very possibly I missed something, but we can get both
> > parent_pid and pid_ns from inode, right? so can't we just remember
> > inode in seq->private?
>
> Good point. Letme check if we will need to call for ihold then...
> (/me scratchig the head)
Why? file/inode can't go away, at least until this fd is closed.
And just in case, get_pid(proc_pid(inode)) is not needed, even in v6/v7.
I didn't realize this.
Cyrill, I won't argue if you prefer to make this in a separate patch
(of course, assuming you are agree) on top of v7, to me it looks
"good enough".
Oleg.
next prev parent reply other threads:[~2012-01-19 16:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 15:32 [RFC] fs, proc: Introduce /proc/<pid>/task/<tid>/children entry v6 Cyrill Gorcunov
2012-01-16 16:11 ` Oleg Nesterov
2012-01-16 16:20 ` Cyrill Gorcunov
2012-01-17 17:40 ` Oleg Nesterov
2012-01-17 17:57 ` Cyrill Gorcunov
2012-01-17 18:14 ` Oleg Nesterov
2012-01-17 18:30 ` Cyrill Gorcunov
2012-01-17 21:38 ` KOSAKI Motohiro
2012-01-18 9:43 ` Cyrill Gorcunov
2012-01-18 13:58 ` Oleg Nesterov
2012-01-18 14:21 ` Cyrill Gorcunov
2012-01-18 14:36 ` Oleg Nesterov
2012-01-18 18:23 ` Cyrill Gorcunov
2012-01-18 19:07 ` Cyrill Gorcunov
2012-01-19 14:10 ` Oleg Nesterov
2012-01-19 14:47 ` Cyrill Gorcunov
2012-01-19 15:55 ` Oleg Nesterov
2012-01-19 16:27 ` Cyrill Gorcunov
2012-01-19 16:44 ` Oleg Nesterov [this message]
2012-01-19 17:07 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119164413.GA16522@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=gorcunov@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=segoon@openwall.com \
--cc=serge.hallyn@canonical.com \
--cc=tj@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).