Re: [PATCH] x86, reboot: skip DMI checks if reboot set by user

Michael D Labriola
2012-01-19T19:14:47Z

"H. Peter Anvin" <hpa@zytor.com> wrote on 01/19/2012 12:52:15 PM:

> On 01/19/2012 09:46 AM, Michael D Labriola wrote:
> >
> > Random question... why do we have a reboot_init function that does
DMI
> > checking with reboot_dmi_table (callbacks are mostly set_bios_reboot,
but
> > there is a single set_kbd_reboot) and also a pci_reboot_init which
does
> > the DMI check again using a separate pci_reboot_dmi_table (all
callbacks
> > are to set_pci_reboot)?
> >
> > Wouldn't it make more sense to do a single DMI scan using one big
table?
> >
>
> Yes, and such a patch would be appreciated.
>
> The reason it is as it is dates back to before the 32-64 bit
> unification, as far as I know.
>
> (BIOS reboot is currently not supported on 64 bits, mainly.)

Well, that does complicate it a bit. I'll gin something up and see what
you think. I guess it will involve having an #ifdef CONFIG_X86_32 block
inside a single dmi_table structure for the BIOS quirks.

Actually, set_kbd_reboot is inside the current X86_32 only block, along
with the one DMI callback that uses it. Is this correct?

---
Michael D Labriola
Electric Boat
mlabriol@gdeb.com
401-848-8871 (desk)
401-848-8513 (lab)
401-316-9844 (cell)