Re: [PATCH] x86, reboot: skip DMI checks if reboot set by user

H. Peter Anvin
2012-01-19T17:53:13Z

On 01/19/2012 09:46 AM, Michael D Labriola wrote:
>
> Random question... why do we have a reboot_init function that does DMI
> checking with reboot_dmi_table (callbacks are mostly set_bios_reboot, but
> there is a single set_kbd_reboot) and also a pci_reboot_init which does
> the DMI check again using a separate pci_reboot_dmi_table (all callbacks
> are to set_pci_reboot)?
>
> Wouldn't it make more sense to do a single DMI scan using one big table?
>

Yes, and such a patch would be appreciated.

The reason it is as it is dates back to before the 32-64 bit
unification, as far as I know.

(BIOS reboot is currently not supported on 64 bits, mainly.)

-hpa