Re: [PATCH] x86, reboot: skip DMI checks if reboot set by user

Michael D Labriola
2012-01-19T15:49:11Z

Alan Cox <alan@lxorguk.ukuu.org.uk> wrote on 01/19/2012 10:45:04 AM:

> > checking if reboot_type's value is anything other than BOOT_ACPI
(which
> > is the default), but that does assume BOOT_ACPI is the default. What
if
> > that's ever changed? Seems likely to me that whoever changes the
default
> > in the future could very easily re-break this at that point.
> >
> > Thoughts?
>
> Fair point - how about a BOOT_DEFAULT define value if it hasn't been set
> and we can just make it do the same as ACPI in the switch ?

Sounds good to me. I'll whip that up and resubmit.

---
Michael D Labriola
Electric Boat
mlabriol@gdeb.com
401-848-8871 (desk)
401-848-8513 (lab)
401-316-9844 (cell)