From: Wolfram Sang <w.sang@pengutronix.de>
To: Austin Boyle <Austin.Boyle@aviatnet.com>
Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] rtc: ds1307: generalise ram size and offset
Date: Thu, 19 Jan 2012 20:45:41 +0100 [thread overview]
Message-ID: <20120119194541.GA32483@pengutronix.de> (raw)
In-Reply-To: <1326320516.3096.64.camel@pc786-ubu.gnet.global.vpn>
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
Sorry, found another thing.
> + if (chip) {
> + if (chip->nvram_size)
> + ds1307->nvram_size = chip->nvram_size;
> + if (chip->nvram_offset)
> + ds1307->nvram_offset = chip->nvram_offset;
> + }
I moved only the assignments...
>
> buf = ds1307->regs;
> if (i2c_check_functionality(adapter, I2C_FUNC_SMBUS_I2C_BLOCK)) {
> @@ -893,11 +907,12 @@ read_rtc:
> dev_dbg(&client->dev, "got IRQ %d\n", client->irq);
> }
>
> - if (chip && chip->nvram56) {
> + if (chip && chip->nvram_size) {
.. to here when I saw...
> + nvram.size = ds1307->nvram_size;
... that nvram is static and we are changing it. Yeah, it is very unlikely but
if we have two RTC with different nvram sizes, one of them will not work correctly.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-01-19 19:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 21:21 [PATCH v3] rtc: ds1307: generalise ram size and offset Austin Boyle
2012-01-09 22:17 ` Wolfram Sang
2012-01-10 0:33 ` Austin Boyle
2012-01-11 11:06 ` Wolfram Sang
2012-01-11 22:21 ` Austin Boyle
2012-01-18 21:41 ` Wolfram Sang
2012-01-19 19:45 ` Wolfram Sang [this message]
2012-02-02 0:37 ` Austin Boyle
2012-02-02 14:53 ` [rtc-linux] " Wolfram Sang
2012-02-02 22:28 ` Austin Boyle
2012-02-07 14:56 ` Wolfram Sang
2012-02-07 21:45 ` Austin Boyle
2012-02-08 22:23 ` [PATCH v4] " Austin Boyle
2012-02-08 22:36 ` Andrew Morton
2012-02-13 14:36 ` Wolfram Sang
2012-02-14 4:23 ` Austin Boyle
2012-02-21 14:00 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2011-11-03 21:07 [PATCH v3] " Austin Boyle
2011-11-03 21:25 ` David Anders
2011-12-19 1:24 ` Austin Boyle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120119194541.GA32483@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=Austin.Boyle@aviatnet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).