From: David Miller <davem@davemloft.net>
To: glommer@parallels.com
Cc: linux-kernel@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
cgroups@vger.kernel.org
Subject: Re: [PATCH 1/3] net: fix socket memcg build with !CONFIG_NET
Date: Fri, 20 Jan 2012 14:14:46 -0500 (EST) [thread overview]
Message-ID: <20120120.141446.136970067758991080.davem@davemloft.net> (raw)
In-Reply-To: <1327071436-20763-2-git-send-email-glommer@parallels.com>
From: Glauber Costa <glommer@parallels.com>
Date: Fri, 20 Jan 2012 18:57:14 +0400
> There is still a build bug with the sock memcg code, that triggers
> with !CONFIG_NET, that survived my series of randconfig builds.
>
> Signed-off-by: Glauber Costa <glommer@parallels.com>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> CC: Hiroyouki Kamezawa <kamezawa.hiroyu@jp.fujitsu.com>
Why are you undoing the static branch optimization? That was a one of
the things that made me agree to even putting this code in.
Find a way to fix this without removing the static branch.
next prev parent reply other threads:[~2012-01-20 19:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 14:57 [PATCH 0/3] fixes for tcp memcg Glauber Costa
2012-01-20 14:57 ` [PATCH 1/3] net: fix socket memcg build with !CONFIG_NET Glauber Costa
2012-01-20 19:14 ` David Miller [this message]
2012-01-21 14:17 ` Glauber Costa
2012-01-22 19:35 ` David Miller
2012-01-20 14:57 ` [PATCH 2/3] cgroup: make sure memcg margin is 0 when over limit Glauber Costa
2012-01-20 17:08 ` Tejun Heo
2012-01-24 8:12 ` Johannes Weiner
2012-01-20 14:57 ` [PATCH 3/3] net: introduce res_counter_charge_nofail() for socket allocations Glauber Costa
2012-01-20 17:07 ` Tejun Heo
2012-01-24 8:15 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120120.141446.136970067758991080.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cgroups@vger.kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=glommer@parallels.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).