From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: Pradheep Shrinivasan <pradheep.sh@gmail.com>,
greg@kroah.com, devel@linuxdriverproject.org,
swetland@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] staging:android_pmem.h: Fixes the space and other formating issues pointed out by checkpatch.pl
Date: Fri, 20 Jan 2012 14:54:09 +0300 [thread overview]
Message-ID: <20120120115408.GL3356@mwanda> (raw)
In-Reply-To: <CAAq6er0OPkvTCLt1DvHSjyqM4pH7GMb-D78M09cJY+1ZV3miiQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
It still complains about the following macros where parenthesis are
not needed.
ERROR: Macros with complex values should be enclosed in parenthesis
#156: FILE: staging/android/pmem.c:156:
+#define PMEM_IS_FREE(id, index) !(pmem[id].bitmap[index].allocated)
Let's just make the check look for an operator with a low
precedence.
http://en.wikipedia.org/wiki/Order_of_operations#Programming_languages
Otherwise the submitters are going to change it to:
#define PMEM_IS_FREE(id, index) (!(pmem[id].bitmap[index].allocated))
That has two pairs of unneeded paranthesis and we run the risk of
reprogramming the kernel in lisp, by mistake.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-20 11:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1326856764-2531-1-git-send-email-pradheep.sh@gmail.com>
[not found] ` <20120118065620.GE3294@mwanda>
[not found] ` <CANz8tm1imZ3njy_uV0tkq0sXwyB5ZLLJsrp4G1zjcBDnJUrjiw@mail.gmail.com>
2012-01-18 18:54 ` [PATCH 1/6] staging:android_pmem.h: Fixes the space and other formating issues pointed out by checkpatch.pl Dan Carpenter
2012-01-20 11:12 ` Andy Whitcroft
2012-01-20 11:54 ` Dan Carpenter [this message]
2012-01-20 12:18 ` Andy Whitcroft
2012-01-20 13:29 ` Joe Perches
2012-01-20 13:50 ` Dan Carpenter
2012-01-20 16:28 ` Andy Whitcroft
2012-01-20 13:15 ` Joe Perches
2012-01-20 13:46 ` Dan Carpenter
2012-01-20 17:12 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120120115408.GL3356@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pradheep.sh@gmail.com \
--cc=swetland@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox