From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756400Ab2AUAEM (ORCPT ); Fri, 20 Jan 2012 19:04:12 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54997 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755647Ab2AUAEJ (ORCPT ); Fri, 20 Jan 2012 19:04:09 -0500 Date: Fri, 20 Jan 2012 16:04:08 -0800 From: Andrew Morton To: Konrad Rzeszutek Wilk Cc: Akinobu Mita , linux-kernel@vger.kernel.org, Jeremy Fitzhardinge Jeremy Fitzhardinge , xen-devel@lists.xensource.com, virtualization@lists.linux-foundation.org Subject: Re: [PATCH] xen-blkfront: use bitmap_set() and bitmap_clear() Message-Id: <20120120160408.9aa3b5fd.akpm@linux-foundation.org> In-Reply-To: <20120120235508.GA17260@phenom.dumpdata.com> References: <1327072528-8479-1-git-send-email-akinobu.mita@gmail.com> <1327072528-8479-4-git-send-email-akinobu.mita@gmail.com> <20120120152819.GA3959@phenom.dumpdata.com> <20120120160938.GC3959@phenom.dumpdata.com> <20120120151149.04352aac.akpm@linux-foundation.org> <20120120235508.GA17260@phenom.dumpdata.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Jan 2012 18:55:08 -0500 Konrad Rzeszutek Wilk wrote: > On Fri, Jan 20, 2012 at 03:11:49PM -0800, Andrew Morton wrote: > > On Fri, 20 Jan 2012 11:09:38 -0500 > > Konrad Rzeszutek Wilk wrote: > > > > > > > > > > > Did you test this patch with a large amount of minors? > > > > > > > > Sorry I didn't do runtime test. > > > > > > Please do. > > > > The poor guy probably doesn't know how to test it and surely it would > > be quite a lot of work for him to do so. > > > > Overall, it would be much more efficient if the tester of this code is > > someone who is set up to easily apply the patch and test it. ie: the > > code maintainer(s). > > > > This patch aside - Andrew how do you deal with a large amount of patches > and make sure they are tested? Not very well :( > Is there a weekly Test Tuesday where you > kick off your automated tests and dilligently look for any variations? > Or is it more of compile the kernel with X features and run it for a week > doing normal (and abnormal!) things to see if it falls over? I build all the patches I have along with all of linux-next and boot the thing, then use the resulting kernel for a few hours compilation testing, then shove it all into linux-next where I naively hope that someone else is testing things. The coverage which is obtained this way is pretty poor.