From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PULL REQUEST] Ext3 & ext2 fix, quota improvement
Date: Fri, 20 Jan 2012 20:05:45 +0100 [thread overview]
Message-ID: <20120120190545.GA18688@quack.suse.cz> (raw)
In-Reply-To: <20120120164400.GA19032@infradead.org>
On Fri 20-01-12 11:44:00, Christoph Hellwig wrote:
> On Fri, Jan 20, 2012 at 05:39:10PM +0100, Jan Kara wrote:
> > quota: Pass information that quota is stored in system file to userspace
>
> Was that patch posted somewhere? How does it apply to e.g. xfs, gfs2
> and ocfs2 that have always stored quota data internally?
It was posted back in November (but I forgot it in a topic branch thus
I'm merging it only now), looking at the post I sent it to linux-ext4 only
which was probably a bit unlucky.
Regarding other filesystems - ocfs2 and gfs2 set DQUOT_QUOTA_SYS_FILE flag
so this will now be passed properly to userspace to inform userspace
programs (but quota-tools anyway use the flag only for ext4, for other
filesystems they know quota is handled internally just by looking at
filesystem type). XFS doesn't set the flag. It does not matter in practice
as XFS doesn't use VFS quota code which cares about the flag
(dquot_quota_sync, dquot_disable) and userspace tools know XFS handles
quota internally. But maybe we could make XFS set it just for consistency?
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2012-01-20 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 16:39 [PULL REQUEST] Ext3 & ext2 fix, quota improvement Jan Kara
2012-01-20 16:44 ` Christoph Hellwig
2012-01-20 19:05 ` Jan Kara [this message]
2012-01-24 14:25 ` Jan Kara
2012-01-24 16:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120120190545.GA18688@quack.suse.cz \
--to=jack@suse.cz \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox